[Adium-devl] XML logging and Message History

[David Smith]

On Feb 7, 2007, at 2:15 PM, Evan Schoenberg wrote:

>
> On Feb 7, 2007, at 9:10 AM, Evan Schoenberg wrote:
>
>>
>> On Feb 7, 2007, at 12:14 AM, Colin Barrett wrote:
>>
>>> I'd like to try turning Dead Code Stripping off and distributing a
>>> build of the same revision as 1.0 to people affected by this  
>>> problem.
>>>
>>> However, to eliminate weirdness potentially caused by me being  
>>> not on
>>> 10.4.8, Evan, do you think you could do this?
>>
>> Good idea.  Build which is identical to 1.0 with a single  
>> difference of Dead Code Stripping disabled has been uploaded to:
>> http://evands.penguinmilitia.net/Adium_1.0-nostrip.dmg
>
> Well, in the logging ticket, anyways, the folks are claiming that  
> this build doesn't exhibit the problem.   I'm really mystified as  
> to how Dead Code Stripping is causing a bug like this... but  
> whatever. The difference is 14 kilobytes.  Shall we turn off DCR  
> for 1.0.1 and treat the bug as fixed unless we get reports with 1.0.1?

	When I first turned DCR on I got a few "wow, you're brave" comments,  
but it didn't seem to cause any problems. I'd definitely not be  
surprised if turning it off did fix the issue, although I'd *love* to  
know why. Speed isn't really an issue (DCR works with some of the  
other optimizers in good ways) and 14k of codesize is also not a  
problem, so I'd go ahead and nuke it.

>
> As far as the invalid file handle exceptions go, there are quite a  
> few ways that NSFIleHandle can throw exceptions (see its  
> documentation) -- I think we should have those writes in an @try/ 
> @catch block and handle exceptions rationally.  For an invalid  
> handle, perhaps we could close the existing file handle, making a  
> new one to the path in question, then try the write again, bailing  
> if the second try doesn't work.  Can you next @try blocks inside  
> @catch blocks?

Nested try/catch should work fine, otherwise it would lead to very  
nonintuitive behavior if you tried to use it in a library. "wait,  
NSNibLoading is in a try block here so I can't do any exception  
processing myself?"

>
> -Evan
>
> _______________________________________________
> Adium-devl mailing list
> Adium-devl at adiumx.com
> http://adiumx.com/mailman/listinfo/adium-devl_adiumx.com