[Adium-devl] XML logging and Message History

[Evan Schoenberg]

On Feb 7, 2007, at 9:10 AM, Evan Schoenberg wrote:

>
> On Feb 7, 2007, at 12:14 AM, Colin Barrett wrote:
>
>> I'd like to try turning Dead Code Stripping off and distributing a
>> build of the same revision as 1.0 to people affected by this problem.
>>
>> However, to eliminate weirdness potentially caused by me being not on
>> 10.4.8, Evan, do you think you could do this?
>
> Good idea.  Build which is identical to 1.0 with a single  
> difference of Dead Code Stripping disabled has been uploaded to:
> http://evands.penguinmilitia.net/Adium_1.0-nostrip.dmg

Well, in the logging ticket, anyways, the folks are claiming that  
this build doesn't exhibit the problem.   I'm really mystified as to  
how Dead Code Stripping is causing a bug like this... but whatever.  
The difference is 14 kilobytes.  Shall we turn off DCR for 1.0.1 and  
treat the bug as fixed unless we get reports with 1.0.1?

As far as the invalid file handle exceptions go, there are quite a  
few ways that NSFIleHandle can throw exceptions (see its  
documentation) -- I think we should have those writes in an @try/ 
@catch block and handle exceptions rationally.  For an invalid  
handle, perhaps we could close the existing file handle, making a new  
one to the path in question, then try the write again, bailing if the  
second try doesn't work.  Can you next @try blocks inside @catch blocks?

-Evan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://adium.im/pipermail/devel_adium.im/attachments/20070207/76fd26ba/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: PGP.sig
Type: application/pgp-signature
Size: 186 bytes
Desc: This is a digitally signed message part
URL: <http://adium.im/pipermail/devel_adium.im/attachments/20070207/76fd26ba/attachment.sig>