[Adium-devl] XML logging and Message History

[Colin Barrett]

On Feb 7, 2007, at 2:15 PM, Evan Schoenberg wrote:

> On Feb 7, 2007, at 9:10 AM, Evan Schoenberg wrote:
>
>>
>> On Feb 7, 2007, at 12:14 AM, Colin Barrett wrote:
>>
>>> I'd like to try turning Dead Code Stripping off and distributing a
>>> build of the same revision as 1.0 to people affected by this  
>>> problem.
>>>
>>> However, to eliminate weirdness potentially caused by me being not  
>>> on
>>> 10.4.8, Evan, do you think you could do this?
>>
>> Good idea.  Build which is identical to 1.0 with a single  
>> difference of Dead Code Stripping disabled has been uploaded to:
>> http://evands.penguinmilitia.net/Adium_1.0-nostrip.dmg
>
> Well, in the logging ticket, anyways, the folks are claiming that  
> this build doesn't exhibit the problem.   I'm really mystified as to  
> how Dead Code Stripping is causing a bug like this... but whatever.  
> The difference is 14 kilobytes.  Shall we turn off DCR for 1.0.1 and  
> treat the bug as fixed unless we get reports with 1.0.1?

Definitely turn off DCR for 1.0.1. My guess is that a method that  
isn't called somehow, but is checked for, gets elided. Also, ObjC is  
pretty dynamic, it's entirely possible a method gets stripped that is  
actually used -- especially in the Events system, where I suspect the  
problem is happening.

I would be on the lookout for any other weird Events related bugs that  
cropped up in Release builds, they may be fixed too.

> As far as the invalid file handle exceptions go, there are quite a  
> few ways that NSFIleHandle can throw exceptions (see its  
> documentation) -- I think we should have those writes in an @try/ 
> @catch block and handle exceptions rationally.  For an invalid  
> handle, perhaps we could close the existing file handle, making a  
> new one to the path in question, then try the write again, bailing  
> if the second try doesn't work.  Can you next @try blocks inside  
> @catch blocks?

I'm wondering if those aren't related to the above.

*Hopefully* they are, but putting some exception handling around that  
certainly couldn't hurt. I'll work on that tomorrow morning.

-Colin