AIM client_login

[Evan Schoenberg, M.D.]

On Jun 2, 2011, at 6:30 PM, Thijs Alkemade wrote:

> rekkanoryo told me clientlogin is now required to use SSL for ICQ. Then I thought, this is newer, it is on by default in Pidgin and working there reliably, so we probably want it on for AIM too.

The logic is sound!  We ran into an unexpected complicated discussed in #15137; I would have made the same move that you did.  

The only think I would have done differently is that the comment is cryptic for someone without context.  Something like:

>> /* Client Login is a newer login method, enabled by default in Pidgin.  It is required to use SSL for ICQ; it is unclear what benefits it provides otherwise. */
>> purple_account_set_bool(account, "use_clientlogin", TRUE);

> I might very well have been wrong in that, I did (and really still do) not know at all how they actually work and I do not know what issues it had in the past.

Me, either :)

> So I changed it intentionally, but if this is broken because of that then we definitely should change it to only apply it for ICQ.

I think this is the best change for 1.4.2, and I'll do it right now.  There will still be a bug - ICQ accounts connecting via SSL when an HTTP proxy is configured, at least with some types or configurations of HTTP proxies, will fail as in #15137 - but it will hit a smaller number of users.

-Evan