AIM client_login

[Thijs Alkemade]

On 3 jun 2011, at 00:48, Evan Schoenberg, M.D. wrote:

> So http://trac.adium.im/ticket/15137 is caused by client_login and the user's proxy configuration not working nicely together.... which led me to wonder why we were using client_login at all. 
> 
> changeset:   3869:e9f94c290817
> user:        Thijs Alkemade <thijsalkemade at gmail.com>
> date:        Sun Apr 17 12:51:21 2011 +0200
> summary:     Change ICQ and AIM encryption settings to no/opportunistic/required encryption.
> 
> In addition to changing how we set the "encryption" setting, we also have:
> 
> +	// Always yes, so SSL on ICQ works again.
> +	purple_account_set_bool(account, "use_clientlogin", TRUE);
> 
> this is done for all OSCAR accounts, not just ICQ, as it's in CBPurpleOscarAccount.
> 
> Thijs, was that intended?  It seems like it should be set for ICQ accounts only, when SSL is to be used...
> 
> Would like to wrap up #15137 before we release.
> 
> -Evan

Hey Evan,

rekkanoryo told me clientlogin is now required to use SSL for ICQ. Then I thought, this is newer, it is on by default in Pidgin and working there reliably, so we probably want it on for AIM too. I might very well have been wrong in that, I did (and really still do) not know at all how they actually work and I do not know what issues it had in the past.

So I changed it intentionally, but if this is broken because of that then we definitely should change it to only apply it for ICQ.

Thijs
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://adium.im/pipermail/devel_adium.im/attachments/20110603/e44652f7/attachment-0002.html>