[Adium-devl] rev 20150 - branches/adium-1.0/Release

[Evan Schoenberg]

On Jul 10, 2007, at 10:16 AM, Juan Manuel Palacios wrote:

> 	One more question though, since you practically greenlight'd me to  
> do it ;-) In r20164 you do this right under the variables section  
> in trunk/Release/Makefile:
>
> +ifeq ($(BETA),TRUE)
> +	BUILDFLAGS="$(BUILDFLAGS) CFLAGS=-DBETA_RELEASE"
> +endif
>
> 	Shouldn't we be appending to the CFLAGS there? That is, shouldn't  
> we instead do CFLAGS += -DBETA_RELEASE? Otherwise we would be  
> completely overriding the inherited cflags, if any. Maybe there  
> aren't any prior to that, but I'd say it's always safe not  
> overriding such an important environment variable. Just my two  
> cents ;-)

I'm a *total* newb in the world of Makefiles.  Could you put a patch  
together doing your improvement, such that -DBETA_RELEASE is in the  
CFLAGS for when BETA is true?

Note:  The Makefile in question is in adium/Releases/, and it calls  
make on the Makefile in adium/.  It was this passing around of  
variables which made me think I had to do something awkward, but  
that's most likely just ignorance talking.

Thanks,
Evan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://adium.im/pipermail/devel_adium.im/attachments/20070710/fb675170/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: PGP.sig
Type: application/pgp-signature
Size: 186 bytes
Desc: This is a digitally signed message part
URL: <http://adium.im/pipermail/devel_adium.im/attachments/20070710/fb675170/attachment.sig>