[Adium-devl] [Adium-svn] rev 20150 - branches/adium-1.0/Release

[Juan Manuel Palacios]

On Jul 9, 2007, at 12:11 PM, Evan Schoenberg wrote:

>
> On Jul 9, 2007, at 1:24 AM, Evan Schoenberg wrote:
>
>> The only difference between Deployment-Debug and Deployment in  
>> terms of the build process is that -DBETA_RELEASE is in the  
>> compilation flags in the former.  Yes, this is very much doable  
>> from the Makefile.  However, this makes the split between built-as- 
>> beta and post-processed-as-beta impossible.
>
> I'm an idiot for saying the above. I'm modifying the Makefile now  
> such that we don't have to make changes in two different files to  
> control the beta process; I'll make the variable names clearer and  
> document their purpose in the process. Thanks for calling the  
> process out for inefficiency!
>
> -Evan


	I'm very glad my comments and questions materialized in actual  
improvements! I also now understand why the last beta is not built in  
beta mode, thanks for the explanation.

	One more question though, since you practically greenlight'd me to  
do it ;-) In r20164 you do this right under the variables section in  
trunk/Release/Makefile:

+ifeq ($(BETA),TRUE)
+	BUILDFLAGS="$(BUILDFLAGS) CFLAGS=-DBETA_RELEASE"
+endif


	Shouldn't we be appending to the CFLAGS there? That is, shouldn't we  
instead do CFLAGS += -DBETA_RELEASE? Otherwise we would be completely  
overriding the inherited cflags, if any. Maybe there aren't any prior  
to that, but I'd say it's always safe not overriding such an  
important environment variable. Just my two cents ;-)

	Regards,...


-jmpp

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://adium.im/pipermail/devel_adium.im/attachments/20070710/369b3d2c/attachment-0001.html>