[Adium-devl] [Adium-svn] rev 20150 - branches/adium-1.0/Release

[Juan Manuel Palacios]

On Jul 9, 2007, at 1:27 AM, Evan Schoenberg wrote:

>
> On Jul 8, 2007, at 11:22 PM, Juan Manuel Palacios wrote:
>
>> 	OK, b4 as amended in a later commit... but if still a beta, don't  
>> we need to address it as such? Why define it to false above?
>
> Poorly named variable.  AIAdiumProtocol.h still defines it as a  
> beta (#define BETA_RELEASE TRUE) which means it uses the beta  
> appcast.  The variable in the makefile determines whether it builds  
> in Deployment-Debug with modifiable nibs and old-style strings  
> files or in Deployment with all space-saving measures in place.   
> The last beta is built in Deployment (removing the debug window, as  
> well) so as to match exactly the actual release.


	So basically, we have to beta markers:

-) a compiler macro that ifdef's some code in/out when building beta/ 
release;
-) a Makefile variable that defines whether the Xcode project is  
built in deployment-debug mode (beta true) or deployment (beta false).

	Is this correct? This is more or less what I had understood until  
now. If so, or at least from what I understand, why have two beta  
markers? Couldn't we do everything with a single one in the Makefile  
from which we decide what to pass to the Adium sources as the  
necessary compiler macro? Something like "BETA = TRUE" in the  
makefile header and then "ifeq(BETA,TRUE) CPPFLAGS += - 
DBETA_RELEASE_TRUE" through out the rest of the Makefile? Or is this  
not doable when calling Xcode builds through makefiles? Or am I  
simply understanding everything the wrong way round...? ;-)

	In any case, wouldn't it be safe to build all betas, even the last,  
in deployment-debug mode? And then if that last one proves release  
ready, simply remove the beta marker and rebuild, plain and simple.  
But still, build *all* betas in beta mode?

>
>> 	Also, I'm only getting a two entries list in the Sparkle  
>> ChangeLog we get through the update check in the Adium menu, but I  
>> know from r20154 that the list is really much larger. Is some URL  
>> pointed in the wrong direction?
>
> You're seeing the changes for moving from 1.0.5b3 to 1.0.5b4.   
> r20154 is changes from 1.0.4 to 1.0.5.


	Right! Sorry for the confusion ;-)

>
> -Evan


-jmpp

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://adium.im/pipermail/devel_adium.im/attachments/20070709/9f8f4ea7/attachment-0001.html>