[Adium-devl] Watching a first time Adium user for 5 minutes

[Evan Schoenberg]

On Jan 26, 2007, at 11:26 PM, Sean Egan wrote:

> On 1/26/07, Evan Schoenberg <evan at adiumx.com> wrote:
>>  The Google Talk client for Windows has some interesting automatic  
>> behaviors
>> I believe -- there are options like "Show All My Contacts" which  
>> shows your
>> address book contacts,
>
> The option you're talking about is just a toggle between a
> scrollbar-less view that chooses and sorts you buddies based on their
> presence and how frequently you IM and e-mail them, and a more
> standard scroll-bar view that shows everyone sorted alphabetically.
>
> The Google Talk client will always show addressbook entries, but the
> former view may not prioritize them high enough to show it there.

Ah hah!  Which explains why Gaim / Adium do, as well, but without any  
sort of choosing-of-contacts, much to the dismay of users -- Adium  
users, anyways.   The following patch, which takes non-subscribed  
users off the local list when the roster is processed, is currently  
in use in Adium's libgaim because we had approximately 100 bug  
reports after the Talk roster changes saying "I'm showing up on my  
buddy list!  All these email addresses I can't IM are on my list!  My  
whole address book is there!!!1111oneonebinary7"

Index: src/protocols/jabber/roster.c
===================================================================
--- src/protocols/jabber/roster.c       (revision 370)
+++ src/protocols/jabber/roster.c       (working copy)
@@ -212,7 +212,9 @@
                 else
                         jb->subscription &= ~JABBER_SUB_PENDING;
-               if(jb->subscription == JABBER_SUB_REMOVE) {
+               //XXX Adium: Don't add subscribe = NONE folk
+               if((jb->subscription == JABBER_SUB_REMOVE) ||
+                  (jb->subscription == JABBER_SUB_NONE)) {
                         remove_gaim_buddies(js, jid);
                 } else {
                         GSList *groups = NULL;

-Evan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://adium.im/pipermail/devel_adium.im/attachments/20070126/da9cd975/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: PGP.sig
Type: application/pgp-signature
Size: 186 bytes
Desc: This is a digitally signed message part
URL: <http://adium.im/pipermail/devel_adium.im/attachments/20070126/da9cd975/attachment.sig>