[Adium-devl] Proposed AIXMLAppender patch for exception handling

[Graham Booker]

Looks pretty good.  I only have one comment:

In the try/catch for [file writeData:], on the Bad file descriptor or  
NSFileHandleOperationException, it closes the file and re-opens it.   
While this could be fine and dandy, it doesn't attempt to write the  
data again should such operations succeed.

On Feb 7, 2007, at 5:32 PM, Evan Schoenberg wrote:

> The attached patch:
>  1. Uses @try/@catch to try to more cleanly handle problems writing  
> out logs
>  2. Moves initialization of the NSFileHandle to -[AIXMLAppender  
> prepareFileHandle] with no significant changes
>  3. Returns a success boolean from the writing / initialization  
> methods which is not used at present but may later be useful
>  4. Fixes a comment typo.
>
> <xml-appender-error-handling.diff>
>
> Could other eyes - but particularly Graham and Colin - take a look  
> at this and see if it seems like an improvement?
>
> Thanks,
> Evan_______________________________________________
> Adium-devl mailing list
> Adium-devl at adiumx.com
> http://adiumx.com/mailman/listinfo/adium-devl_adiumx.com


- Graham