[Adium-devl] Proposed AIXMLAppender patch for exception handling

Evan Schoenberg evan.s at dreskin.net
Wed Feb 7 23:32:57 UTC 2007


The attached patch:
  1. Uses @try/@catch to try to more cleanly handle problems writing  
out logs
  2. Moves initialization of the NSFileHandle to -[AIXMLAppender  
prepareFileHandle] with no significant changes
  3. Returns a success boolean from the writing / initialization  
methods which is not used at present but may later be useful
  4. Fixes a comment typo.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: xml-appender-error-handling.diff
Type: application/octet-stream
Size: 8514 bytes
Desc: not available
URL: <http://adium.im/pipermail/devel_adium.im/attachments/20070207/af417571/attachment.obj>
-------------- next part --------------

Could other eyes - but particularly Graham and Colin - take a look at  
this and see if it seems like an improvement?

Thanks,
Evan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: PGP.sig
Type: application/pgp-signature
Size: 186 bytes
Desc: This is a digitally signed message part
URL: <http://adium.im/pipermail/devel_adium.im/attachments/20070207/af417571/attachment.sig>


More information about the devel mailing list