[Adium-devl] Fixing the 1.1 launch mess

[Chris Forsythe]

heh, first psmtabs are maintained by us, and now sparkle looks like  
it might have to be?

Let's see if we can get it up on maccode or something.

Chris

On Aug 14, 2007, at 11:05 AM, David Smith wrote:

> 	I've spoken with Andy about Sparkle (he's rooming with my brother at
> caltech, conveniently enough), and he wants/wanted nothing to do with
> it. His original plan was to release 1.0 and move on. I'm not
> convinced that's the way to go. In this *particular* case, the
> problem seems to have been that we're the first to use the
> minimumSystemVersion key (which makes some sense, I added it for us).
> I suspect Coda and other similar apps will begin running into it once
> they release a Leopard only version.
>
> 							David
>
> On Aug 14, 2007, at 3:30 AM, Evan Schoenberg wrote:
>
>> Great work, Peter and everyone else who helped to fix this
>> situation so quickly, elegantly, and professionally!
>>
>> Looking at the root problem, it seems that S+ isn't being closely
>> maintained.  I think the best solution is to talk to Andy about
>> moving its changes to Sparkle itself and linking all non-current-
>> Sparkle behavior to a plist key or the like, without which the
>> current Sparkle behavior would occur.
>>
>> Cheers,
>> Evan
>>
>> On Aug 13, 2007, at 6:20 PM, Peter Hosey wrote:
>>
>>> The story so far, based on my description of it to Colin this
>>> afternoon over AIM:
>>>
>>> ---
>>> We hadn't declared the minimumSystemVersion in the appcast, so
>>> Panther users were downloading 1.1.
>>>
>>> Evan added it (<http://trac.adiumx.com/changeset/20572>), but he
>>> added it as an attribute of the enclosure element, where Sparkle
>>> and S+ do not look for it, so the Panther users were still
>>> downloading it.
>>>
>>> So I moved it to an element inside the feed item element, sibling
>>> to the enclosure element (<http://trac.adiumx.com/changeset/
>>> 20573>), and that's what really brought out the breakage.
>>>
>>> Turns out that Sparkle had a bug 5 months ago in its minimum
>>> system version checking that did not retain the string containing
>>> the minimum system version, so when -appcastDidFinishLoading: was
>>> called, the string object was not technically alive anymore, yet
>>> SUUpdater tried to compare it to another version.
>>>
>>> That bug got carried over to S+, whence it came into Adium.
>>>
>>> 5 months ago, Andy fixed it (<http://sparkle.andymatuschak.org/
>>> changeset/13>), but that fix did not get into S+ (somehow).
>>>
>>> The bug was masked before because we didn't have a minimum system
>>> version declared, at least anywhere where Sparkle was looking for
>>> it. But once I moved the version to an element, now Sparkle was
>>> finding it, and not retaining it, and comparing it, and choking on
>>> it.
>>>
>>> Presto: Crash on launch for almost all new 1.1 users and 1.0.5  
>>> users.
>>> ---
>>>
>>> So here's what I suggest:
>>>
>>> 1. Take 1.1 and the minimumSystemVersion elements out of the  
>>> appcast.
>>> 2. Push 1.0.6 with the fixed Sparkle+, for the benefit of Panther
>>> users.
>>> 3. 24 hours later, release 1.1.1, put it in the appcast, and
>>> restore the minimumSystemVersion elements.
>>>
>>> Do we have any disagreements with this plan?
>>>
>>> _______________________________________________
>>> Adium-devl mailing list
>>> Adium-devl at adiumx.com
>>> http://adiumx.com/mailman/listinfo/adium-devl_adiumx.com
>>
>> _______________________________________________
>> Adium-devl mailing list
>> Adium-devl at adiumx.com
>> http://adiumx.com/mailman/listinfo/adium-devl_adiumx.com
>
>
> _______________________________________________
> Adium-devl mailing list
> Adium-devl at adiumx.com
> http://adiumx.com/mailman/listinfo/adium-devl_adiumx.com