www/adiumxtras.com 44:be2a8d9c2f71: Attempt to cut down on spam ...

commits at adium.im commits at adium.im
Fri Feb 20 22:37:50 UTC 2015


details:	http://hg.adium.im/www/adiumxtras.com/rev/be2a8d9c2f71
revision:	44:be2a8d9c2f71
branch:		adiumxtras.com
author:		Thijs Alkemade <me at thijsalkema.de>
date:		Fri Feb 20 23:37:23 2015 +0100

Attempt to cut down on spam by switching to the new recaptcha API.

diffs (307 lines):

diff -r f8c2a22f117d -r be2a8d9c2f71 recaptchalib.php
--- a/recaptchalib.php	Thu Jan 10 13:27:23 2013 -0500
+++ b/recaptchalib.php	Fri Feb 20 23:37:23 2015 +0100
@@ -45,13 +45,13 @@
  * @return string - encoded request
  */
 function _recaptcha_qsencode ($data) {
-        $req = "";
-        foreach ( $data as $key => $value )
-                $req .= $key . '=' . urlencode( stripslashes($value) ) . '&';
+  $req = "";
+  foreach ( $data as $key => $value )
+          $req .= $key . '=' . urlencode( stripslashes($value) ) . '&';
 
-        // Cut the last '&'
-        $req=substr($req,0,strlen($req)-1);
-        return $req;
+  // Cut the last '&'
+  $req=substr($req,0,strlen($req)-1);
+  return $req;
 }
 
 
@@ -66,29 +66,16 @@
  */
 function _recaptcha_http_post($host, $path, $data, $port = 80) {
 
-        $req = _recaptcha_qsencode ($data);
+  $req = _recaptcha_qsencode ($data);
 
-        $http_request  = "POST $path HTTP/1.0\r\n";
-        $http_request .= "Host: $host\r\n";
-        $http_request .= "Content-Type: application/x-www-form-urlencoded;\r\n";
-        $http_request .= "Content-Length: " . strlen($req) . "\r\n";
-        $http_request .= "User-Agent: reCAPTCHA/PHP\r\n";
-        $http_request .= "\r\n";
-        $http_request .= $req;
+  $fp = fopen("https://" . $host . $path . "?" . $req, 'r');
 
-        $response = '';
-        if( false == ( $fs = @fsockopen($host, $port, $errno, $errstr, 10) ) ) {
-                die ('Could not open socket');
-        }
+  while ( !feof($fp) )
+          $response .= fgets($fp, 1160); // One TCP-IP packet
+  fclose($fp);
+  $response = json_decode($response, TRUE);
 
-        fwrite($fs, $http_request);
-
-        while ( !feof($fs) )
-                $response .= fgets($fs, 1160); // One TCP-IP packet
-        fclose($fs);
-        $response = explode("\r\n\r\n", $response, 2);
-
-        return $response;
+  return $response;
 }
 
 
@@ -103,29 +90,23 @@
 
  * @return string - The HTML to be embedded in the user's form.
  */
-function recaptcha_get_html ($pubkey, $error = null, $use_ssl = false)
+function recaptcha_get_html ($pubkey, $error = null, $use_ssl = true)
 {
-	if ($pubkey == null || $pubkey == '') {
-		die ("To use reCAPTCHA you must get an API key from <a href='https://www.google.com/recaptcha/admin/create'>https://www.google.com/recaptcha/admin/create</a>");
-	}
-	
-	if ($use_ssl) {
-                $server = RECAPTCHA_API_SECURE_SERVER;
-        } else {
-                $server = RECAPTCHA_API_SERVER;
-        }
+  if ($pubkey == null || $pubkey == '') {
+    die ("To use reCAPTCHA you must get an API key from <a href='https://www.google.com/recaptcha/admin/create'>https://www.google.com/recaptcha/admin/create</a>");
+  }
 
-        $errorpart = "";
-        if ($error) {
-           $errorpart = "&error=" . $error;
-        }
-        return '<script type="text/javascript" src="'. $server . '/challenge?k=' . $pubkey . $errorpart . '"></script>
+  if ($use_ssl) {
+    $server = RECAPTCHA_API_SECURE_SERVER;
+  } else {
+    $server = RECAPTCHA_API_SERVER;
+  }
 
-	<noscript>
-  		<iframe src="'. $server . '/noscript?k=' . $pubkey . $errorpart . '" height="300" width="500" frameborder="0"></iframe><br/>
-  		<textarea name="recaptcha_challenge_field" rows="3" cols="40"></textarea>
-  		<input type="hidden" name="recaptcha_response_field" value="manual_challenge"/>
-	</noscript>';
+  $errorpart = "";
+  if ($error) {
+    $errorpart = "&error=" . $error;
+  }
+  return '<script src="https://www.google.com/recaptcha/api.js" async defer></script><div class="g-recaptcha" data-sitekey="' . $pubkey . '"></div>';
 }
 
 
@@ -151,44 +132,42 @@
   */
 function recaptcha_check_answer ($privkey, $remoteip, $challenge, $response, $extra_params = array())
 {
-	if ($privkey == null || $privkey == '') {
-		die ("To use reCAPTCHA you must get an API key from <a href='https://www.google.com/recaptcha/admin/create'>https://www.google.com/recaptcha/admin/create</a>");
-	}
+  if ($privkey == null || $privkey == '') {
+    die ("To use reCAPTCHA you must get an API key from <a href='https://www.google.com/recaptcha/admin/create'>https://www.google.com/recaptcha/admin/create</a>");
+  }
 
-	if ($remoteip == null || $remoteip == '') {
-		die ("For security reasons, you must pass the remote ip to reCAPTCHA");
-	}
+  if ($remoteip == null || $remoteip == '') {
+    die ("For security reasons, you must pass the remote ip to reCAPTCHA");
+  }
 
-	
-	
-        //discard spam submissions
-        if ($challenge == null || strlen($challenge) == 0 || $response == null || strlen($response) == 0) {
-                $recaptcha_response = new ReCaptchaResponse();
-                $recaptcha_response->is_valid = false;
-                $recaptcha_response->error = 'incorrect-captcha-sol';
-                return $recaptcha_response;
-        }
 
-        $response = _recaptcha_http_post (RECAPTCHA_VERIFY_SERVER, "/recaptcha/api/verify",
-                                          array (
-                                                 'privatekey' => $privkey,
-                                                 'remoteip' => $remoteip,
-                                                 'challenge' => $challenge,
-                                                 'response' => $response
-                                                 ) + $extra_params
-                                          );
 
-        $answers = explode ("\n", $response [1]);
-        $recaptcha_response = new ReCaptchaResponse();
+  //discard spam submissions
+  if ($response == null || strlen($response) == 0) {
+          $recaptcha_response = new ReCaptchaResponse();
+          $recaptcha_response->is_valid = false;
+          $recaptcha_response->error = 'incorrect-captcha-sol';
+          return $recaptcha_response;
+  }
 
-        if (trim ($answers [0]) == 'true') {
-                $recaptcha_response->is_valid = true;
-        }
-        else {
-                $recaptcha_response->is_valid = false;
-                $recaptcha_response->error = $answers [1];
-        }
-        return $recaptcha_response;
+  $response = _recaptcha_http_post (RECAPTCHA_VERIFY_SERVER, "/recaptcha/api/siteverify",
+                                    array (
+                                           'secret' => $privkey,
+                                           'remoteip' => $remoteip,
+                                           'response' => $response
+                                           ) + $extra_params
+                                    );
+
+  $recaptcha_response = new ReCaptchaResponse();
+
+  if (trim ($response["success"]) == TRUE) {
+          $recaptcha_response->is_valid = true;
+  }
+  else {
+          $recaptcha_response->is_valid = false;
+          $recaptcha_response->error = $response["error-codes"];
+  }
+  return $recaptcha_response;
 
 }
 
@@ -200,44 +179,44 @@
  * @param string $appname The name of your application
  */
 function recaptcha_get_signup_url ($domain = null, $appname = null) {
-	return "https://www.google.com/recaptcha/admin/create?" .  _recaptcha_qsencode (array ('domains' => $domain, 'app' => $appname));
+  return "https://www.google.com/recaptcha/admin/create?" .  _recaptcha_qsencode (array ('domains' => $domain, 'app' => $appname));
 }
 
 function _recaptcha_aes_pad($val) {
-	$block_size = 16;
-	$numpad = $block_size - (strlen ($val) % $block_size);
-	return str_pad($val, strlen ($val) + $numpad, chr($numpad));
+  $block_size = 16;
+  $numpad = $block_size - (strlen ($val) % $block_size);
+  return str_pad($val, strlen ($val) + $numpad, chr($numpad));
 }
 
 /* Mailhide related code */
 
 function _recaptcha_aes_encrypt($val,$ky) {
-	if (! function_exists ("mcrypt_encrypt")) {
-		die ("To use reCAPTCHA Mailhide, you need to have the mcrypt php module installed.");
-	}
-	$mode=MCRYPT_MODE_CBC;   
-	$enc=MCRYPT_RIJNDAEL_128;
-	$val=_recaptcha_aes_pad($val);
-	return mcrypt_encrypt($enc, $ky, $val, $mode, "\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0");
+  if (! function_exists ("mcrypt_encrypt")) {
+    die ("To use reCAPTCHA Mailhide, you need to have the mcrypt php module installed.");
+  }
+  $mode=MCRYPT_MODE_CBC;
+  $enc=MCRYPT_RIJNDAEL_128;
+  $val=_recaptcha_aes_pad($val);
+  return mcrypt_encrypt($enc, $ky, $val, $mode, "\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0");
 }
 
 
 function _recaptcha_mailhide_urlbase64 ($x) {
-	return strtr(base64_encode ($x), '+/', '-_');
+  return strtr(base64_encode ($x), '+/', '-_');
 }
 
 /* gets the reCAPTCHA Mailhide url for a given email, public key and private key */
 function recaptcha_mailhide_url($pubkey, $privkey, $email) {
-	if ($pubkey == '' || $pubkey == null || $privkey == "" || $privkey == null) {
-		die ("To use reCAPTCHA Mailhide, you have to sign up for a public and private key, " .
-		     "you can do so at <a href='http://www.google.com/recaptcha/mailhide/apikey'>http://www.google.com/recaptcha/mailhide/apikey</a>");
-	}
-	
+  if ($pubkey == '' || $pubkey == null || $privkey == "" || $privkey == null) {
+    die ("To use reCAPTCHA Mailhide, you have to sign up for a public and private key, " .
+         "you can do so at <a href='http://www.google.com/recaptcha/mailhide/apikey'>http://www.google.com/recaptcha/mailhide/apikey</a>");
+  }
 
-	$ky = pack('H*', $privkey);
-	$cryptmail = _recaptcha_aes_encrypt ($email, $ky);
-	
-	return "http://www.google.com/recaptcha/mailhide/d?k=" . $pubkey . "&c=" . _recaptcha_mailhide_urlbase64 ($cryptmail);
+
+  $ky = pack('H*', $privkey);
+  $cryptmail = _recaptcha_aes_encrypt ($email, $ky);
+
+  return "http://www.google.com/recaptcha/mailhide/d?k=" . $pubkey . "&c=" . _recaptcha_mailhide_urlbase64 ($cryptmail);
 }
 
 /**
@@ -246,16 +225,16 @@
  * the email is then displayed as john... at example.com
  */
 function _recaptcha_mailhide_email_parts ($email) {
-	$arr = preg_split("/@/", $email );
+  $arr = preg_split("/@/", $email );
 
-	if (strlen ($arr[0]) <= 4) {
-		$arr[0] = substr ($arr[0], 0, 1);
-	} else if (strlen ($arr[0]) <= 6) {
-		$arr[0] = substr ($arr[0], 0, 3);
-	} else {
-		$arr[0] = substr ($arr[0], 0, 4);
-	}
-	return $arr;
+  if (strlen ($arr[0]) <= 4) {
+    $arr[0] = substr ($arr[0], 0, 1);
+  } else if (strlen ($arr[0]) <= 6) {
+    $arr[0] = substr ($arr[0], 0, 3);
+  } else {
+    $arr[0] = substr ($arr[0], 0, 4);
+  }
+  return $arr;
 }
 
 /**
@@ -265,13 +244,13 @@
  * http://www.google.com/recaptcha/mailhide/apikey
  */
 function recaptcha_mailhide_html($pubkey, $privkey, $email) {
-	$emailparts = _recaptcha_mailhide_email_parts ($email);
-	$url = recaptcha_mailhide_url ($pubkey, $privkey, $email);
-	
-	return htmlentities($emailparts[0]) . "<a href='" . htmlentities ($url) .
-		"' onclick=\"window.open('" . htmlentities ($url) . "', '', 'toolbar=0,scrollbars=0,location=0,statusbar=0,menubar=0,resizable=0,width=500,height=300'); return false;\" title=\"Reveal this e-mail address\">...</a>@" . htmlentities ($emailparts [1]);
+  $emailparts = _recaptcha_mailhide_email_parts ($email);
+  $url = recaptcha_mailhide_url ($pubkey, $privkey, $email);
+
+  return htmlentities($emailparts[0]) . "<a href='" . htmlentities ($url) .
+    "' onclick=\"window.open('" . htmlentities ($url) . "', '', 'toolbar=0,scrollbars=0,location=0,statusbar=0,menubar=0,resizable=0,width=500,height=300'); return false;\" title=\"Reveal this e-mail address\">...</a>@" . htmlentities ($emailparts [1]);
 
 }
 
 
-?>
+?>
\ No newline at end of file
diff -r f8c2a22f117d -r be2a8d9c2f71 xtras.php
--- a/xtras.php	Thu Jan 10 13:27:23 2013 -0500
+++ b/xtras.php	Fri Feb 20 23:37:23 2015 +0100
@@ -65,8 +65,8 @@
 			require_once('recaptchalib.php');
 			$resp = recaptcha_check_answer (RECAPTCHA_PRIV_KEY,
 											$_SERVER["REMOTE_ADDR"],
-											$_POST["recaptcha_challenge_field"],
-											$_POST["recaptcha_response_field"]);
+											NULL,
+											$_POST["g-recaptcha-response"]);
 			if ($resp->is_valid) {
 				if ($_POST['comment'] && $_POST['xtra_id']) {
 					if (currentUID()) {




More information about the commits mailing list