adium 4867:d78e9b1cdc69: Most ESTextAndButtonsWindowController r...

[commits at adium.im]

details:	http://hg.adium.im/adium/rev/d78e9b1cdc69
revision:	4867:d78e9b1cdc69
branch:		adium-1.5.2
author:		Thijs Alkemade <thijsalkemade at gmail.com>
date:		Mon Jun 11 11:17:12 2012 +0200

Most ESTextAndButtonsWindowController run independently: after calling -show, -release should not be called, as they'll release themselves when they're done.

Fix GBQuestionHandlerPlugin to adhere to that, so it doesn't crash when finishing.

Fixes #15900

diffs (13 lines):

diff -r b9d9c8a21067 -r d78e9b1cdc69 Source/GBQuestionHandlerPlugin.m
--- a/Source/GBQuestionHandlerPlugin.m	Fri Jun 08 13:17:40 2012 +0200
+++ b/Source/GBQuestionHandlerPlugin.m	Mon Jun 11 11:17:12 2012 +0200
@@ -105,7 +105,8 @@
 		ret = NO;
 	else
 	{
-		[currentAlert release];
+		// Note: Explicitly not released here: ESTextAndButtonsWindowController will autorelease itself in -windowWillClose:
+		[currentAlert close];
 		currentAlert = nil;
 	}
 	return ret;