adium 4857:39eb15c93519: We haven't needed an implementation her...

commits at adium.im commits at adium.im
Sun Jun 10 16:24:44 UTC 2012


details:	http://hg.adium.im/adium/rev/39eb15c93519
revision:	4857:39eb15c93519
branch:		(none)
author:		Frank Dowsett <wixardy at adium.im>
date:		Sun Jun 10 12:00:20 2012 -0400

We haven't needed an implementation here since it's handled in the window controller.
Subject: adium 4858:92db93164d65: As of 10.5 there exists a non-private API.

details:	http://hg.adium.im/adium/rev/92db93164d65
revision:	4858:92db93164d65
branch:		(none)
author:		Frank Dowsett <wixardy at adium.im>
date:		Sun Jun 10 12:00:28 2012 -0400

As of 10.5 there exists a non-private API.
Subject: adium 4859:3692c6d45956: merge from default

details:	http://hg.adium.im/adium/rev/3692c6d45956
revision:	4859:3692c6d45956
branch:		ARC
author:		Frank Dowsett <wixardy at adium.im>
date:		Sat Jun 09 10:36:46 2012 -0400

merge from default
Subject: adium 4860:a1058d311200: Use some newer, non-deprecated Keychain certificate methods.

details:	http://hg.adium.im/adium/rev/a1058d311200
revision:	4860:a1058d311200
branch:		ARC
author:		Frank Dowsett <wixardy at adium.im>
date:		Sat Jun 09 15:32:00 2012 -0400

Use some newer, non-deprecated Keychain certificate methods.
Subject: adium 4861:52594d1da8c9: Fix some warnings about direct access to isa in JSONKit by using object_getClass; the speed difference is negligible.

details:	http://hg.adium.im/adium/rev/52594d1da8c9
revision:	4861:52594d1da8c9
branch:		ARC
author:		Frank Dowsett <wixardy at adium.im>
date:		Sat Jun 09 18:13:29 2012 -0400

Fix some warnings about direct access to isa in JSONKit by using object_getClass; the speed difference is negligible.
Subject: adium 4862:4f1da722ffaf: Fix the encoding for AHHyperlinkScanner and remove some duplicate characters that were added in 3f3c8fd24679.

details:	http://hg.adium.im/adium/rev/4f1da722ffaf
revision:	4862:4f1da722ffaf
branch:		ARC
author:		Frank Dowsett <wixardy at adium.im>
date:		Sat Jun 09 18:13:29 2012 -0400

Fix the encoding for AHHyperlinkScanner and remove some duplicate characters that were added in 3f3c8fd24679.
Subject: adium 4863:fc73bd728f52: Save some precision.

details:	http://hg.adium.im/adium/rev/fc73bd728f52
revision:	4863:fc73bd728f52
branch:		ARC
author:		Frank Dowsett <wixardy at adium.im>
date:		Sat Jun 09 18:13:30 2012 -0400

Save some precision.
Subject: adium 4864:b730a194ef1b: Correct many format strings.

details:	http://hg.adium.im/adium/rev/b730a194ef1b
revision:	4864:b730a194ef1b
branch:		ARC
author:		Frank Dowsett <wixardy at adium.im>
date:		Sat Jun 09 19:38:31 2012 -0400

Correct many format strings.
Subject: adium 4865:87cab9e762dc: Prevent a zombie after closing the password prompt.

details:	http://hg.adium.im/adium/rev/87cab9e762dc
revision:	4865:87cab9e762dc
branch:		ARC
author:		Frank Dowsett <wixardy at adium.im>
date:		Sat Jun 09 21:00:28 2012 -0400

Prevent a zombie after closing the password prompt.
Subject: adium 4866:05168b11a63b: Save some precision.

details:	http://hg.adium.im/adium/rev/05168b11a63b
revision:	4866:05168b11a63b
branch:		(none)
author:		Frank Dowsett <wixardy at adium.im>
date:		Sat Jun 09 18:13:30 2012 -0400

Save some precision.
(transplanted from fc73bd728f522c001c8f32ce9d39372ac96528cc)

diffs (65 lines):

diff -r 3a4a1f3c4295 -r 05168b11a63b Source/AIContactInfoContentController.h
--- a/Source/AIContactInfoContentController.h	Fri Jun 08 18:31:32 2012 -0400
+++ b/Source/AIContactInfoContentController.h	Sat Jun 09 18:13:30 2012 -0400
@@ -36,7 +36,4 @@
 - (NSArray *)loadedPanes;
 - (void)loadContentPanes:(NSArray *)contentPanes;
 
-//Segmented Control action
--(IBAction)segmentSelected:(id)sender;
-
 @end
diff -r 3a4a1f3c4295 -r 05168b11a63b Source/AIContactInfoContentController.m
--- a/Source/AIContactInfoContentController.m	Fri Jun 08 18:31:32 2012 -0400
+++ b/Source/AIContactInfoContentController.m	Sat Jun 09 18:13:30 2012 -0400
@@ -82,9 +82,4 @@
 	[self _setLoadedPanes:contentArray];
 }
 
--(IBAction)segmentSelected:(id)sender
-{
-#warning Needs implementation
-}
-
 @end
diff -r 3a4a1f3c4295 -r 05168b11a63b Source/AICreateCommand.m
--- a/Source/AICreateCommand.m	Fri Jun 08 18:31:32 2012 -0400
+++ b/Source/AICreateCommand.m	Sat Jun 09 18:13:30 2012 -0400
@@ -30,7 +30,6 @@
  */
 - (id)performDefaultImplementation
 {
-#warning This uses a Private API
 	NSScriptClassDescription *newObjectDescription = [self createClassDescription];	
 	id target = [self subjectsSpecifier];
 
@@ -64,16 +63,13 @@
 
 /**
  * @brief returns the object in the 'subj' key in this apple event.
- *
- * This uses a private API. It's the only way I've found to get the target of the 'make' command, which is necessary 
- * in order to override performDefaultImplementation.
  */
 - (id)subjectsSpecifier
 {
 	NSAppleEventDescriptor *subjDesc = [[self appleEvent] attributeDescriptorForKeyword: 'subj'];
 	if ([subjDesc aeDesc] && [subjDesc aeDesc]->descriptorType == typeNull)
 		return nil;
-	NSScriptObjectSpecifier *subjSpec = [NSScriptObjectSpecifier _objectSpecifierFromDescriptor: subjDesc inCommandConstructionContext: nil];
+	NSScriptObjectSpecifier *subjSpec = [NSScriptObjectSpecifier objectSpecifierWithDescriptor:subjDesc];
 	return [subjSpec objectsByEvaluatingSpecifier];
 }
 @end
diff -r 3a4a1f3c4295 -r 05168b11a63b Source/AIXtrasManager.m
--- a/Source/AIXtrasManager.m	Fri Jun 08 18:31:32 2012 -0400
+++ b/Source/AIXtrasManager.m	Sat Jun 09 18:13:30 2012 -0400
@@ -459,7 +459,7 @@
 - (void)tableViewSelectionDidChange:(NSNotification *)aNotification
 {
 	if ([aNotification object] == xtraList) {
-		int	selectedRow = [xtraList selectedRow];
+		NSInteger selectedRow = [xtraList selectedRow];
 		if ((selectedRow >= 0) && (selectedRow < [selectedCategory count])) {
 			//AIXtraInfo *xtraInfo  = [AIXtraInfo infoWithURL:[NSURL fileURLWithPath:[[selectedCategory objectAtIndex:selectedRow] path]]];
 		//	if ([[xtraList selectedRowIndexes] count] == 1)




More information about the commits mailing list