adium-1.4 3611:85165a4ab9cb: In what must be the longest standin...

commits at adium.im commits at adium.im
Sun Aug 21 20:51:03 UTC 2011


details:	http://hg.adium.im/adium-1.4/rev/85165a4ab9cb
revision:	3611:85165a4ab9cb
branch:		(none)
author:		Evan Schoenberg
date:		Sun Aug 21 15:50:25 2011 -0500

In what must be the longest standing leak in the history of Adium, we weren't releasing the view heirarchy owned by AIMessageViewController (since it loads it with itself as owner from the nib in its init method). This, in turn, made every AIChat leak, since AIMessageTextEntryView retains its AIChat...
(transplanted from db9fbeb2372ee2b90d41e21796aa4a1bf1dd826d)

diffs (12 lines):

diff -r 93c8292bc1c8 -r 85165a4ab9cb Plugins/Dual Window Interface/AIMessageViewController.m
--- a/Plugins/Dual Window Interface/AIMessageViewController.m	Sun Aug 21 15:14:33 2011 -0500
+++ b/Plugins/Dual Window Interface/AIMessageViewController.m	Sun Aug 21 15:50:25 2011 -0500
@@ -226,7 +226,7 @@
 	}
 	//release menuItem
 	[showHide release];
-	
+	[view_contents release]; view_contents = nil;
 	[undoManager release]; undoManager = nil;
 
     [super dealloc];




More information about the commits mailing list