adium 4156:db9fbeb2372e: In what must be the longest standing le...
commits at adium.im
commits at adium.im
Sun Aug 21 20:50:32 UTC 2011
details: http://hg.adium.im/adium/rev/db9fbeb2372e
revision: 4156:db9fbeb2372e
branch: (none)
author: Evan Schoenberg
date: Sun Aug 21 15:50:25 2011 -0500
In what must be the longest standing leak in the history of Adium, we weren't releasing the view heirarchy owned by AIMessageViewController (since it loads it with itself as owner from the nib in its init method). This, in turn, made every AIChat leak, since AIMessageTextEntryView retains its AIChat...
diffs (12 lines):
diff -r a9560a8f30eb -r db9fbeb2372e Plugins/Dual Window Interface/AIMessageViewController.m
--- a/Plugins/Dual Window Interface/AIMessageViewController.m Sun Aug 21 15:14:33 2011 -0500
+++ b/Plugins/Dual Window Interface/AIMessageViewController.m Sun Aug 21 15:50:25 2011 -0500
@@ -199,7 +199,7 @@
//release menuItem
[showHide release];
-
+ [view_contents release]; view_contents = nil;
[undoManager release]; undoManager = nil;
[super dealloc];
More information about the commits
mailing list