adium 3015:28c5afeed769: Trusting a static analysis tool leads t...

[commits at adium.im]

details:	http://hg.adium.im/adium/rev/28c5afeed769
revision:	3015:28c5afeed769
author:		Zachary West <zacw at adium.im>
date:		Wed Dec 02 14:01:57 2009 -0500

Trusting a static analysis tool leads to crashes.
(transplanted from da21e69184ae115db952bcd6d95eeb140ea11cec)

diffs (21 lines):

diff -r 7ac554f5036f -r 28c5afeed769 Source/AISpecialPasswordPromptController.m
--- a/Source/AISpecialPasswordPromptController.m	Wed Dec 02 11:47:23 2009 -0500
+++ b/Source/AISpecialPasswordPromptController.m	Wed Dec 02 14:01:57 2009 -0500
@@ -56,14 +56,15 @@
 		[controller setTarget:inTarget selector:inSelector context:inContext];
 		
 	} else {
-		if ((controller = [[[self alloc] initWithWindowNibName:SPECIAL_ACCOUNT_PASSWORD_PROMPT 
+		// Do not trust the static analyzer, look at the superclass. This is not a leak.
+		if ((controller = [[self alloc] initWithWindowNibName:SPECIAL_ACCOUNT_PASSWORD_PROMPT 
 												   forAccount:inAccount 
 														 type:inType
 														 name:inName
 													 password:inPassword
 											  notifyingTarget:inTarget
 													 selector:inSelector
-													  context:inContext] autorelease])) {
+													  context:inContext])) {
 			[passwordPromptControllerDict setObject:controller
 											 forKey:identifier];
 		}