adium-1.4 2868:da21e69184ae: Trusting a static analysis tool lea...

[commits at adium.im]

details:	http://hg.adium.im/adium-1.4/rev/da21e69184ae
revision:	2868:da21e69184ae
author:		Zachary West <zacw at adium.im>
date:		Wed Dec 02 14:01:57 2009 -0500

Trusting a static analysis tool leads to crashes.

diffs (21 lines):

diff -r 0e217cd9c984 -r da21e69184ae Source/AISpecialPasswordPromptController.m
--- a/Source/AISpecialPasswordPromptController.m	Wed Dec 02 11:47:23 2009 -0500
+++ b/Source/AISpecialPasswordPromptController.m	Wed Dec 02 14:01:57 2009 -0500
@@ -56,14 +56,15 @@
 		[controller setTarget:inTarget selector:inSelector context:inContext];
 		
 	} else {
-		if ((controller = [[[self alloc] initWithWindowNibName:SPECIAL_ACCOUNT_PASSWORD_PROMPT 
+		// Do not trust the static analyzer, look at the superclass. This is not a leak.
+		if ((controller = [[self alloc] initWithWindowNibName:SPECIAL_ACCOUNT_PASSWORD_PROMPT 
 												   forAccount:inAccount 
 														 type:inType
 														 name:inName
 													 password:inPassword
 											  notifyingTarget:inTarget
 													 selector:inSelector
-													  context:inContext] autorelease])) {
+													  context:inContext])) {
 			[passwordPromptControllerDict setObject:controller
 											 forKey:identifier];
 		}