adium-1.4 3614:062a27e5858b: Added MAZeroingWeakRef

[Evan Schoenberg, M.D.]

On Aug 21, 2011, at 7:23 PM, Thijs Alkemade wrote:

> 
> On 21 aug. 2011, at 23:47, commits at adium.im wrote:
> 
>> details:	http://hg.adium.im/adium-1.4/rev/062a27e5858b
>> revision:	3614:062a27e5858b
>> branch:		(none)
>> author:		Evan Schoenberg
>> date:		Sun Aug 21 16:17:51 2011 -0500
>> 
>> Added MAZeroingWeakRef
>> (transplanted from 13d1f4765a893ca51ac912172b365f4ddae937d2)
>> Subject: adium-1.4 3615:dd4b532eb0d5: Silenced some more nib warnings in xcode 4.2
> 
> I didn't check what this is used for or what it is, but it breaks our build:
> 
> ---
> 
> Undefined symbols:
>   "__Block_object_dispose", referenced from:
>       ___destroy_helper_block_4 in MAZeroingWeakRef.o
>       ___destroy_helper_block_4 in MAZeroingWeakRef.o
>       ___Block_byref_id_object_dispose3.94842 in MAZeroingWeakRef.o
>       ___destroy_helper_block_3 in MAZeroingWeakRef.o
>       ___destroy_helper_block_2 in MAZeroingWeakRef.o
>       ___destroy_helper_block_2 in MAZeroingWeakRef.o
>       ___destroy_helper_block_1 in MAZeroingWeakRef.o
>       -[MAZeroingWeakRef target] in MAZeroingWeakRef.o
>   "__Block_object_assign", referenced from:
>       ___copy_helper_block_4 in MAZeroingWeakRef.o
>       ___copy_helper_block_4 in MAZeroingWeakRef.o
>       ___Block_byref_id_object_copy3.94838 in MAZeroingWeakRef.o
>       ___copy_helper_block_3 in MAZeroingWeakRef.o
>       ___copy_helper_block_2 in MAZeroingWeakRef.o
>       ___copy_helper_block_2 in MAZeroingWeakRef.o
>       ___copy_helper_block_1 in MAZeroingWeakRef.o
>   "__NSConcreteStackBlock", referenced from:
>       __NSConcreteStackBlock$non_lazy_ptr in MAZeroingWeakRef.o
>      (maybe you meant: __NSConcreteStackBlock$non_lazy_ptr)
> ld: symbol(s) not found
> collect2: ld returned 1 exit status
> 
> ---
> 
> (http://buildbot.adium.im/builders/adium-1.4/builds/552/steps/compile/logs/stdio)
> 
> It looks like this is because blocks can't be used on 10.5.

Apologies.  Looks like I over-trusted the third-party code; seeing that it was, as Chris pointed out, using the NS_BLOCKS_AVAILABLE check, I didn't verify the rest of it on a 10.5 build.  Fixing it now.

-Evan

> 
> Thijs

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://adium.im/pipermail/devel_adium.im/attachments/20110821/5b0d69eb/attachment-0002.html>