message styles in 1.4

[Matthew]

On Sat, May 22, 2010 at 08:14, Christopher Forsythe <chris at growl.info> wrote:
>
>
> On Fri, May 21, 2010 at 11:38 AM, Matthew <mneedham at ei8ht.us> wrote:
>>
>> On Thu, May 20, 2010 at 18:38, Evan Schoenberg, M.D. <evan at adium.im>
>> wrote:
>>
>> > We should just not allow bundled styles to appear on AdiumXtras.com.
>> >  Done
>> > and done.  If you want to publish a variant of a bundled style, post it
>> > with
>> > a unique name.
>> > -Evan
>>
>> That would work for styles that first appeared within Adium, but for
>> most of the bundled styles, the cat's already out of the bag. In fact,
>> The bundled styles were chosen because they were already very popular
>> on Xtras. This guarantees that many users will have
>> duplicate/conflicting message styles the first time a style on Xtras
>> is bundled.
>>
>> I *do* think it would be beneficial to do a bit more checking of
>> message styles before they are approved. A message style has to have a
>> unique name set in three different places, and It's not that unusual
>> for someone who mods an existing style to fail to "fix" one of more of
>> the three places. I only recently added this to the wiki, so maybe it
>> will improve. However,  I'm guessing that implementing a check for
>> this would require an overhaul of Xtras, and I'm not expecting that to
>> happen anytime soon.
>>
>>
>
>
> Or just a validator script the reviewer runs locally. ;)
> Chris

Wouldn't the site need to track each of the three values for every
existing style to ensure that there are no dupes? I don't see how a
local-only script could do that. You also have to consider that many
existing styles would be invalidated.


-- 

Matthew