Crash in adium

[David Smith]

While I'd normally agree with you, the odds of anyone subclassing AIPurpleFacebookAccount (and therefore running into the fragile base class problem) are pretty much nil. That said, writing a new account type that uses the existing info is probably just about as easy.

	David

On Apr 17, 2010, at 11:26 AM, Luke the Hiesterman wrote:

> This is generally a bad idea. I'm assuming that's a libPurple class, by the name, and while it might be possible to get away with that sort of thing at the application level, changing the superclass of a library class is a bad idea. You're better off deprecating the current class and writing a new one with the class you want.
> 
> Luke 
> 
> On Apr 17, 2010, at 11:18 AM, Peter Hosey wrote:
> 
>> On Apr 17, 2010, at 11:12:49, David Smith wrote:
>>> We'll likely be removing the existing facebook code in favor of an xmpp facebook account type; just need to write a migration path for existing users.
>> 
>> Would it be possible to change the superclasses of our Facebook classes (e.g., PurpleFacebookAccount) without changing where they look for settings? We might not need to migrate anything.
>> 
>> If that's not currently possible, I think we should look into making it so.
>> 
>> 
> 
>