[Adium-devl] MSNp15 (libpurple im.pidgin.pidgin) in Adium 1.3.x

[Felipe Contreras]

On Wed, Sep 10, 2008 at 9:05 PM, Marcos Saraiva <msaraiva at gmail.com> wrote:
> Again, as a user, i have to add my $0.02 cents. Just look at the thread
> where Dimmuxx used to release unofficial Adium builds...it was full of
> people giving positive feedback and thanking him for making a build with
> MSNP15 readily available to all, because it has more features than msnp9
> (and also msn-pecan) and is stable enough for daily usage. And to
> corroborate that, i'm building Adium myself and moved to trunk, for the sole
> reason that MSNP15 is available there. I'd really like you to look at the
> situation without being biased by the fact that you mantain msn-pecan.

I'm not biased. Of course I'm defending my project, but I also
understand your position. If you follow common sense msnp15 is the
right choice. What I'm trying to make you understand is that
appearances are deceiving.

It's not biased to say the code of msnp15 is inferior, it's a fact
that I can prove, but apparently you are not interested. If it works
great for you and for some people that doesn't mean the code is good.

In fact, I helped to stabilize msnp15. Masca told me there was one
weird issue nobody could find the cause, so I decided to help and in
the process I found an horrendous piece of code that made me wonder
how is it possible that the whole thing actually works.

The solution I suggested and that QuLogic implemented was to revert
back the old, and correct, behavior.

Are you telling me that the issues I found are not there? Is it just my bias?

There is code that works by chance, it might work fine today, and then
suddenly break horribly. That is why code has values: readability,
documentation, maintainability, modularity. And why code reviewing,
and refactoring are highly valued.

[1] http://pidgin.im/pipermail/devel/2008-June/006161.html

-- 
Felipe Contreras