[Adium-devl] [Adium-svn] rev 23712 - trunk/Plugins/Facebook Service

[Juan Manuel Palacios]

On May 29, 2008, at 6:03 AM, Evan Schoenberg wrote:

>
> On May 29, 2008, at 1:30 AM, Juan Manuel Palacios wrote:
>
>>
>> On May 28, 2008, at 6:30 AM, evands at adiumx.com wrote:
>>
>>> Author: evands
>>> Date: 2008-05-28 07:00:54 -0400 (Wed, 28 May 2008)
>>> New Revision: 23712
>>>
>>> Modified:
>>>  trunk/Plugins/Facebook Service/AIFacebookAccount.m
>>> Log:
>>> Reverted attempted to use https://login.facebook.com/login.php; I  
>>> don't understand why it doesn't work for us but does for pidgin- 
>>> facebook. Retained disconnection ability and sending typing  
>>> notifications gleaned from pidgin-facebook.
>>>
>>
>> 	Just a small question, hoping I'm not out of line asking this (in  
>> case it's already common knowledge): why isn't Adium using (or  
>> waiting to use, in case it's not mainline yet) libpurple's Facebook  
>> prpl? This is about the third or fourth commit attesting to Adium's  
>> lower Facebook-fu as compared to libpurple's, so it got me  
>> wondering why the functionality is being re-implemented in house.
>
>
> Adium's lower Facebook-fu?  Our implementation is more elegant than  
> pidgin-facebook


	I apologize if I was out of line, didn't mean to offend! And,...

> (and predates it).


	Definitely did not know that! /me bows again.

> Our sign-in process, due to oddness with cookie handling, requires  
> loading one extra page of text... which works fine. Otherwise,  
> there's nothing inferior about our implementation and plenty that is  
> more flexible and cleaner.  pidgin-facebook had implemented typing  
> notifications, which weren't previously documented as far as I knew,  
> and I added them to our Facebook Service in a couple minutes total.
>
> In addition to preferring my implementation to pidgin-facebook's,  
> we're not set up to make use of pidgin prpls which aren't compiled  
> statically, anyways, with the new build system. I messed with this a  
> while to try to get msn-pecan working before declaring bankruptcy on  
> it.  If someone were to fix that, it'd open the door for various fun  
> things, but I'd still think we should skip the libpurple  
> implementation.


	Word! I was just wondering... ;-)

>
> -Evan


	Regards,...


-jmpp

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://adium.im/pipermail/devel_adium.im/attachments/20080529/933c67fc/attachment-0001.html>