[Adium-devl] Fwd: Building msn_pecan statically

[Felipe Contreras]

On Mon, Jun 30, 2008 at 6:31 PM, Evan Schoenberg <evan.s at dreskin.net> wrote:
>
> On Jun 30, 2008, at 11:18 AM, Felipe Contreras wrote:
>
>>> ===
>>> --- Makefile.am.old     2008-06-30 10:58:08.000000000 -0400
>>> +++ Makefile.am 2008-06-30 11:03:30.000000000 -0400
>>> @@ -65,5 +65,5 @@
>>>      -I$(top_builddir)/libpurple \
>>>      $(GLIB_CFLAGS) \
>>>      $(DEBUG_CFLAGS) \
>>> -       -DHAVE_LIBPURPLE
>>> -       -DVERSION=0.0.15git
>>> +       -DHAVE_LIBPURPLE \
>>> +       -DVERSION='"0.0.15git"'
>>> ===
>>
>> Also, the version should now be obtained with the "./get-version.sh"
>> script.
>>
>> version := $(shell $(srcdir)/get-version.sh)
>>
>> -D VERSION='"$(version)"'
>
> Thanks. I added the -DVERSION at the last minute having noticed that I was
> previously manually changing msn.h since the VERSION #define wasn't
> available (as it is set in the Makefile).  Please do add the corrected
> Makefile.am to trunk - there's no reason for the automake file not to be
> part of the distribution.

Makefile.am wouldn't be used. Only when somebody tries to compile it
statically, which I doubt anyone will try.

Makes sense for Adium right now, but that's it.

> Clarification on git branches: If one has a theoretical 'adium' branch
> checked out, one still gets all changes from the master/origin branch?

You have local and remote branches. Some local branches are linked to
remote branches, so git-pull will get all the changes appropriately.

I will make 'adium' a special branch, so it will be the master branch
+ a few commits, so you wouldn't have to worry about this.

Best regards.

-- 
Felipe Contreras