[Adium-devl] Fwd: Merging i.p.cpw.qulogic.msn to i.p.p

[Felipe Contreras]

On Wed, Jul 9, 2008 at 5:26 PM, John Bailey <rekkanoryo at rekkanoryo.org> wrote:
> Felipe Contreras wrote:
>> Please see:
>> http://pidgin.im/pipermail/devel/2008-June/006161.html
>>
>> Basically each time you receive a server error you'll have memory
>> corruption and eventually crash. This could easily be avoided by
>> removing the "is_num(str)" in that code, however, you'll need more
>> changes to properly handle the errors that have payloads, for which
>> you would have to make design changes, reverting to msnp9 behavior
>> regarding command handling; not a trivial task.
>>
>> But yeah, it would be interesting to see how it works on Adium.
>>
>> Regarding msn-pecan, I have almost narrowed down all the obvious
>> critical issues, probably the next release would be ready for the
>> masses.
>>
>> Best regards.
>
> You need to follow what actually happens more closely instead of wasting your
> time bitching about what you see as design flaws in mtn that no one on the
> Pidgin development team cares about.  The code you object to has been removed
> from that branch, and thus will be removed from im.pidgin.pidgin when it is merged.

Yeah, 13 hours ago, without mentioning the fact that I discovered the
bug, and no reply on the mailing list. Considering that I'm leaving
the project I don't think I should be expected to know what's
happening in all the msn-related branches all the time.

And again, if there are indeed error commands that have a payload;
you'll get very bad behavior. And again, it's not a trivial change and
the chance of more bugs popping out is high.

And my mtn comments in the pidgin mailing list have no relevance
whatsoever here. Stop the flame bait.

-- 
Felipe Contreras