[Adium-devl] Auto alignment of message input field

[Evan Schoenberg]

On Jan 18, 2008, at 4:52 AM, Ofri Wolfus wrote:

> So would anyone like to commit this patch?

I'd still like to know more about something that's being proposed to  
be run with every keystroke to benefit for a very very very small  
minority of users ("people who type in two languages within a single  
message, one of which is right-to-left and one of which is left-to- 
right").  Where's the FriBidi framework's source code?

-Evan

>
>
> On 13/01/2008, at 00:00, Ofri Wolfus wrote:
>
>>
>> On 10/01/2008, at 02:17, Peter Hosey wrote:
>>
>>> On 2008-01-09, at 14:41, Ofri Wolfus wrote:
>>>> … the entire string is being sent a -baseWritingDirection which is
>>>> quite cheap in most cases.
>>>
>>> How cheap is -[NSTextStorage string]? Keeping in mind that, IIRC,
>>> insertText: gets called with nearly every keypress when the text  
>>> view
>>> is active.
>>
>> NSTextStorage is an NSAttributedString subclass, and the docs of -
>> [NSAttributedString string] says the following: "For performance
>> reasons, this method returns the current backing store of the
>> attributed string object. ... This primitive method must guarantee
>> efficient access to an attributed string’s characters; subclasses
>> should implement it to execute in O(1) time."
>> So I believe it's fast enough. I haven't seen any performance change
>> on my macbook.
>>
>>>> This is needed in order to handle the case where a use types
>>>> something, deletes everything, and then types again in a different
>>>> language, or when moving the typing marker to the beginning and
>>>> inserting new text there.
>>>
>>> Is it broken currently? If so, is there a ticket?
>>
>> What is broken? This is a new feature, not a bug fix.
>
>
> _______________________________________________
> Adium-devl mailing list
> Adium-devl at adiumx.com
> http://adiumx.com/mailman/listinfo/adium-devl_adiumx.com
>