[Adium-devl] PURPLE_MESSAGE_SEND

[Evan Schoenberg]

On Jan 6, 2008, at 10:37 PM, Eion Robb wrote:

> So before I try and fix it, is there any good reason that Adium  
> ignores
> PURPLE_MESSAGE_SEND flagged IM's?
>
> Cryptically, adiumPurpleConvWriteIm() in adiumPurpleConversation.m  
> says
> "We only care about this if it does not have the PURPLE_MESSAGE_SEND  
> flag,
> which is set if Purple is sending a sent message back to us" which  
> doesn't
> mean much to me.
>
> Before you ask, the protocol that I'm implementing can recieve IM  
> messages
> sent by the sender but on a different machine, kinda like a
> synchronisation of messages, since a user can be logged into multiple
> locations at one time.

Every message sent gets mirrored back to adiumPurpleConvWriteIm() by  
libpurple with PURPLE_MESSAGE_SEND in its flags.  Adium displays the  
message itself before passing the information to the account for  
sending; not ignoring this information would result in every sent  
message being displayed twice in the current setup.  (The above reads  
the same to me as the comment in adiumPurpleConversation - if it  
clarifies it for you, could you point out what was confusing compared  
to your new understanding?  If it doesn't, I'll be happy to discuss it  
further.)

I'm definitely open to suggestions as to how to make any part of Adium  
better, including this - please don't take That's The Way It Is as  
implying That's The Way It Must Be, at any level of the program.   
Sometimes improvements only become clear as a need arrives and not  
before.

-Evan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://adium.im/pipermail/devel_adium.im/attachments/20080106/44dbff36/attachment-0001.html>