[Adium-devl] Trac "patch status" field

[Evan Schoenberg]

I've added a "Patch" custom field to Trac.  I think this should  
replace the "Patch included" checkbox. Current values:
---
None
Initially Included
Needs Discussion
Needs Dev Review
Needs Changes by Author
OK; Needs Check-In
Accepted
---
Are there any other values that it should have?  My thinking is that  
we'll ask patch submitters to set the ticket to "Initially Included"  
when they attach the patch.  Needs Discussion will be used when it's  
questionable whether the patch should be included in Adium or not; if  
it's a bug fix or decidedly a good thing but needs code review,  
that's what "Needs Dev Review" will be.  I welcome suggestions as to  
different phrasings that might be more clear - much better to make  
changes now than later.

Trac doesn't want to let old custom fields die... so there's a  
duplicate copy of "Patch" from when I had named it  
"field_patchstatus" before deciding that name was ugly.  I didn't  
expect it to keep both around... as a temporary work around, I've  
added the custom field back with a label of "(Remove Me)" and a type  
of "hidden" -- which is invalid -- so that there aren't two seemingly  
valid dropdowns.  I'd appreciate it if someone could ask in #trac or  
ask a Trac developer what we need to do to remove all references to  
an old custom field.

The only place the "field_patchstatus" field is used is in #6541  
where I tried it out before changing it to "patch_status".  We'll  
want to be able to remove the "field_haspatch" checkbox, as well.

Cheers,
Evan


-------------- next part --------------
A non-text attachment was scrubbed...
Name: PGP.sig
Type: application/pgp-signature
Size: 186 bytes
Desc: This is a digitally signed message part
URL: <http://adium.im/pipermail/devel_adium.im/attachments/20070318/46798d9b/attachment.sig>