[Adium-devl] Code for 1.0 Review: Fix closing authorization request windows when an account signs off

Evan Schoenberg evan.s at dreskin.net
Wed Jan 31 18:18:32 UTC 2007


Prior to recent betas, the authorization request system in libgaim  
simply sent a standard action request via the request API.  Recently,  
this was improved to work through an authorization-specific  
callback.  This added a bug, however, because such windows did not  
automatically close when the account disconnected, and once an  
account disconnects a response to an authorization request window  
would crash (previously, the request API automatically handled the  
situation).

The libgaim changeset and the adium changesets are attached  
separately.  Please take a look at both... given our timeframe, I'm  
going to go ahead and push a release candidate with these changes in  
a little bit, but we can easily back them out if there are any  
problems found upon review.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: libgaim-account-request.diff
Type: application/octet-stream
Size: 5616 bytes
Desc: not available
URL: <http://adium.im/pipermail/devel_adium.im/attachments/20070131/a006f100/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: adium-account-auth-close.diff
Type: application/octet-stream
Size: 4286 bytes
Desc: not available
URL: <http://adium.im/pipermail/devel_adium.im/attachments/20070131/a006f100/attachment-0001.obj>
-------------- next part --------------

-Evan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: PGP.sig
Type: application/pgp-signature
Size: 186 bytes
Desc: This is a digitally signed message part
URL: <http://adium.im/pipermail/devel_adium.im/attachments/20070131/a006f100/attachment.sig>


More information about the devel mailing list