[Adium-devl] Module Refactorization

[Colin Barrett]

On Jan 29, 2007, at 8:43 AM, disposable at infinitenexus.com wrote:

> I'm all for it, but I disagree with the line
> "Remember that refactoring is most likely to be successful when you
> are adding a feature or fixing a bug. This should be the main focus
> of the refactoring!"
>
> It implies the need to 'add something' to justify the refactoring -
> refactoring doesn't need to be justified, it improves code clarity
> and if nothing breaks, meets its requirements.

David suggested this, and speaking  from practical experience, I have  
to agree. Anything useful that has gotten done in Adium has gotten  
done because of adding a feature or fixing a bug.

"The contact controller is hella broken, there are tons of bugs with  
metas and lots of ugly code" meets that criteria. "This code is really  
old and a little crufty, but it seems to be working," (example:  
AIMenuController) does not.

Sorry if that was a bit unclear. Maybe this should be added  
(footnote?) or that description on the wiki altered a bit.

-Colin