[Adium-devl] Adium-svn rev 18741 - trunk/Source

[Colin Barrett]

On Jan 29, 2007, at 7:15 AM, Evan Schoenberg wrote:

>
> On Jan 29, 2007, at 10:47 AM, cbarrett at adiumx.com wrote:
>
>> +	// Hide the "Add to my Contact List" checkbox if the contact  
>> already exists in the list
>> +	if (![[adium contactController] existingContactWithService: 
>> [account service] account:account UID:[infoDict  
>> objectForKey:@"Remote Name"]]) {
>> +		[checkBox_addToList setState:NSOffState];
>> +		[checkBox_addToList setEnabled:NO];
>> +		[checkBox_addToList setHidden:YES];
>> +	}
>> +
>
> Was that tested?

By patr1ck, yes.

> 1) Isn't it the opposite of the check which should be performed?

However, I modified the patch to be from `call != nil` to `!call`. My  
fault.

> 2) There can be an existing contact without it being on the  
> account's list; for example, if the person has messaged the contact,  
> an AIListContact will have been created and the method will return  
> that contact.   The check should be for an existingContacts'  
> remoteGroupName != nil.

I thought about this when reviewing his patch, and assumed that the  
contact controller wouldn't store things in it's contactDict not on  
the list. Guess I was wrong. Will roll in the isStranger patch  
momentarily.

-Colin