[Adium-devl] Adium-svn rev 18741 - trunk/Source

[Evan Schoenberg]

On Jan 29, 2007, at 10:47 AM, cbarrett at adiumx.com wrote:

> +	// Hide the "Add to my Contact List" checkbox if the contact  
> already exists in the list
> +	if (![[adium contactController] existingContactWithService: 
> [account service] account:account UID:[infoDict  
> objectForKey:@"Remote Name"]]) {
> +		[checkBox_addToList setState:NSOffState];
> +		[checkBox_addToList setEnabled:NO];
> +		[checkBox_addToList setHidden:YES];
> +	}
> +

Was that tested?

1) Isn't it the opposite of the check which should be performed?
2) There can be an existing contact without it being on the account's  
list; for example, if the person has messaged the contact, an  
AIListContact will have been created and the method will return that  
contact.   The check should be for an existingContacts'  
remoteGroupName != nil.

-Evan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://adium.im/pipermail/devel_adium.im/attachments/20070129/09a6c2a6/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: PGP.sig
Type: application/pgp-signature
Size: 186 bytes
Desc: This is a digitally signed message part
URL: <http://adium.im/pipermail/devel_adium.im/attachments/20070129/09a6c2a6/attachment.sig>