[Adium-devl] Watching a first time Adium user for 5 minutes

[Evan Schoenberg]

On Jan 28, 2007, at 11:42 AM, Andreas Monitzer wrote:

>> which is currently done in the few remaining places (are there any?)
>
> Apparently, there are, otherwise your tester wouldn't have gotten
> that message.
Mm?  String comparisons are done in a bunch of places... but how is
strcmp(message, "INVALID_PASSWORD") == 0
any different than
strcmp(message, "Invalid Password") == 0

besides that the former requires us to maintain a translation?

My point about not many places doing "this" was that "this" is  
extracting substituted values back out again.

The problem was that a new string had been added and we didn't  
notice.  Specifically, the AIM service now distinguishes between  
"Invalid screenname" and "Invalid password" whereas previously there  
was a single message, "Invalid nickname or password".

>
>> it's needed by looking at the strings before and after the
>> substituted text.  If the libgaim string changed,we'd still have to
>> update *something* to get the "translation" again.
>
> It would only be necessary if the number of arguments or something
> similar changed.
If any part of the string changed, the localization would need to be  
updated.  "Foo %x" != "Foo %x  bar"... so if we had "Foo %x" =  
"THIS_IS_FOO_IDENTIFIER–%x" as the translation, that translation  
would no longer be used if the underlying string changed to "Foo %x  
bar". We'd need to update the translation.

> Of course, this is a bad hack due to the fact that gaim doesn't
> separate the backend and GUI properly, and should be phased out
> eventually.
Well, if you're willing to Just Accept the strings libgaim chooses to  
provide, and display them as requested, then none of this is  
necessary.. but we're not.
Part of the problem with such a split is that since the Gaim core  
supports plugins which could do anything, including providing  
additional protocols, you can't have a centralized singlee list of  
possible messages.  There's just so much text passed from protocol to  
core to UI... it'll be a huge undertaking to find a way to do that in  
a non-UI (identifiers rather than text) fashion.


-Evan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://adium.im/pipermail/devel_adium.im/attachments/20070128/1939356c/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: PGP.sig
Type: application/pgp-signature
Size: 186 bytes
Desc: This is a digitally signed message part
URL: <http://adium.im/pipermail/devel_adium.im/attachments/20070128/1939356c/attachment.sig>