[Adium-devl] Hoping you're awake

[Evan Schoenberg]

On Jan 12, 2007, at 10:20 AM, Eric Richie wrote:

> On 1/12/07 1:54 AM, "Evan Schoenberg" <evan.s at dreskin.net> wrote:
>>>
>> 1) There's heavy debug logging in the UPNP code; there's a common  
>> libgaim crash in that code which happens in do_port_mapping_cb()  
>> which is somehow called on the same upnp attempt twice.. the first  
>> one frees the associated struct, the second time cashes... and if  
>> you have a upnp router which triggers it (not all upnp routers do  
>> it seems) you basically are in for a crash fest.  I'd really like  
>> someone to reproduce the crash with log-to-file enabled in the  
>> debug window.. i think  if i can see what series of things  
>> happened leading  up to it I can fix it in fairly short order.
>>
> I was reproducing this one before like clockwork so if I get a  
> chance this afternoon/tonight after work I’ll try to get some more  
> logs for it.
>

Great :) There's a big nasty crasher in 1.0b23... I didn't review  
what appeared to be an innocuous patch thoroughly enough, and it ends  
up causing Adium to crash whenever a window resizes after closing the  
log viewer.  Goes to show that even simple changes can have major  
impacts.  I was going to go ahead and push the fix this afternoon,  
but if you can get me the debug output maybe we can fix that, too,  
before doing a final beta.

-Evan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://adium.im/pipermail/devel_adium.im/attachments/20070112/6ebec2f5/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: PGP.sig
Type: application/pgp-signature
Size: 186 bytes
Desc: This is a digitally signed message part
URL: <http://adium.im/pipermail/devel_adium.im/attachments/20070112/6ebec2f5/attachment.sig>