[Adium-devl] Hoping you're awake

[Evan Schoenberg]

On Jan 12, 2007, at 1:43 AM, Augie Fackler wrote:

> Anywho, the plan is I'm going to make an rc1 and we'll put it in  
> the #adium topic for ~24 hours, and then we'll push an appcast for  
> it if there's no issues, then if still clean, make it 1.0final :)
>
1) There's heavy debug logging in the UPNP code; there's a common  
libgaim crash in that code which happens in do_port_mapping_cb()  
which is somehow called on the same upnp attempt twice.. the first  
one frees the associated struct, the second time cashes... and if you  
have a upnp router which triggers it (not all upnp routers do it  
seems) you basically are in for a crash fest.  I'd really like  
someone to reproduce the crash with log-to-file enabled in the debug  
window.. i think  if i can see what series of things happened  
leading  up to it I can fix it in fairly short order.

2)  I'd like to have a final deployment-debug build and then a second  
build, identical but in Deployment since that's what we'll use for  
1.0, in the release-candidate series.  The last deployment-debug  
could be called another beta, no fanfare or 'this is a release  
candidate', then assuming no problems the deployment one would be rc1.

> I'm going to call a code freeze on the 1.0 branch so nobody commits  
> to it...
Word.  If that libgaim crash can be fixed, we'll still add that in..  
but otherwise, hands off :)

Actually, 2 minor things to look at in there:
1) http://www.visualdistortion.org/crash/view.jsp?crash=251375
Thread 0 Crashed:
0   <<00000000>> 	0xfffeff10 objc_msgSend_rtp   16
1   com.apple.Foundation           	0x929505d0  
_NSDescriptionWithLocaleFunc   72
2   com.apple.CoreFoundation       	0x907c2ad0  
_CFStringAppendFormatAndArgumentsAux   4096
3   com.apple.CoreFoundation       	0x907c1988  
_CFStringCreateWithFormatAndArgumentsAux   144
4   com.apple.Foundation           	0x92945abc -[NSPlaceholderString  
initWithFormat:locale:arguments:]   140
5   com.apple.Foundation           	0x92945a10  [NSString  
stringWithFormat:]   72
6   com.adiumX.adiumX              	0x000ba830 - 
[ESFileTransferController stringForSize:of:ofString:]   628
7   com.adiumX.adiumX              	0x000c6a68 - 
[ESFileTransferProgressRow gotUpdateForFileTransfer:]   151
in German only.  Resources/German.lproj/Localizable.strings must have  
some printf-style formatter wrong in one of the strings used in  
stringForSize:of:ofString: -- I thought I fixed it, but the crash  
reported there is with an updated Localizable.strings I sent the dude  
to try, one which matches current svn with the fix I committed.  
Weird.  Another set of eyes see anything?

2) http://www.visualdistortion.org/crash/view.jsp?crash=251361
Moral of the story: I hate case sensitivity.  Is a single letter  
miscapitilized somewhere? I don't actually care too much about this,  
but if it's a single letter we may as well fix it.  I hate case  
sensitivity and people who use it, in fact.  Except for you, dear  
reader.  You're on adium-devl; you're fine.

> Good luck on that 8AM thing :)
Thanks :)

-Evan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://adium.im/pipermail/devel_adium.im/attachments/20070112/9d12cf0c/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: PGP.sig
Type: application/pgp-signature
Size: 186 bytes
Desc: This is a digitally signed message part
URL: <http://adium.im/pipermail/devel_adium.im/attachments/20070112/9d12cf0c/attachment.sig>