[Adium-devl] Empty Directory File Transfers

[Evan Schoenberg]

Quoting Erich Kreutzer <eagleeye87 at gmail.com>:

> While finalizing support for bonjour file transfer I ran into a
> question about directory transfers.  If you try to send an empty
> folder in iChat either through AIM or Bonjour the following dialog
> appears:
>
> "File transfer error
> There are no files in the selected folder
> 			( OK )"
>
> Adium presents no such dialog.  For all of the libpurple protocols,
> Adium just zips the empty folder and then attempts to send that.  I
> feel that it would be better to display a dialog similar to that of
> iChat.  I, however, am not familiar enough with all of the protocols
> so would this be the expected behavior for all file transfers?
>
> If that behavior is okay I would suggest Adium present the following
> dialog:
>
> "File Transfer Error
> The folder you selected can't be sent because it contains no files.
> 		( OK )"

That sounds like fine behavior to me - I can't envision any use case  
for sending an empty folder.  Beware the .DS_Store files (which  
shouldn't count as making the folder non-empty) when checking folder  
contents for emptiness.

We should probably check against 0-byte files, too -- I believe I  
recall this currently throwing a libpurple error ("This file can not  
be sent because it is 0 bytes" or something like that) and then  
leaving the poor file transfer stranded in 'initiating' per the File  
Transfer Progress window.

Cheers,
Evan


----------------------------------------------------------------
This message was sent using IMP, the Internet Messaging Program.