[Adium-devl] AIApplicationAdditions changes in [20513] / [20515] / [20517]

[Evan Schoenberg]

1.
What are these changes for?  We've gone from single mathematical  
operation (a constant compared to a constant) to loading a file from  
disk, parsing it to a dictionary, extracting a string from  the  
dictionary, creating an array out of it, then comparing values from  
that array.

2.
For higher == YES,
		if(major >= majorVersion || (major >= majorVersion && minor >=  
minorVersion) || (major >= majorVersion && minor >= minorVersion &&  
point >= pointVersion))

The major >= majorVersion within each OR is duplicative - you hit it  
initially.  I think you probably meant:
		if(major >= majorVersion || (major == majorVersion && minor >=  
minorVersion) || (major == majorVersion && minor == minorVersion &&  
point >= pointVersion))

but i'm not positive.

3.
isTiger returns NO on any version of 10.4 later than 10.4.0.   
Similarly for isLeopard and 10.5.  For what purpose do we need to  
know if the user is on a particular OS?

Cheers,
Evan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://adium.im/pipermail/devel_adium.im/attachments/20070810/b98f92ee/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: PGP.sig
Type: application/pgp-signature
Size: 186 bytes
Desc: This is a digitally signed message part
URL: <http://adium.im/pipermail/devel_adium.im/attachments/20070810/b98f92ee/attachment.sig>