[Adium-devl] Major Adium 1.1 leak

[Evan Schoenberg]

On Apr 16, 2007, at 2:06 PM, Peter Hosey wrote:

> On Apr 16, 2007, at 07:47:16, Evan Schoenberg wrote:
>> AIMessageWindowController and AIMesageWindow do deallocate
>> AIMessageTabViewItem gets down to a retain count of 1
>
> You have a circular retain. Here's your ownership chart:
>
> 	tab view
> 		tab view item
> 			chat (representedObject of tab view item)
> 				tab view item (status object property of chat)
> 					*bam*crunch*tinkle*

I thought the same initially.... but we intentionally break that  
circle in -[AIDualWindowInterfacePlugin closeChat:], which is the  
entry point for closing the tab at all (and which debug logging shows  
does get hit properly).

- (void)closeChat:(AIChat *)chat
{
	AIMessageTabViewItem		*messageTab = [chat  
statusObjectForKey:@"MessageTabViewItem"];
	AIMessageWindowController	*container = [messageTab container];
	
	//Close the chat
	[container removeTabViewItem:messageTab silent:NO];
	[chat setStatusObject:nil
				   forKey:@"MessageTabViewItem"
				   notify:NotifyNever];
}

-Evan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://adium.im/pipermail/devel_adium.im/attachments/20070416/d8d40002/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: PGP.sig
Type: application/pgp-signature
Size: 186 bytes
Desc: This is a digitally signed message part
URL: <http://adium.im/pipermail/devel_adium.im/attachments/20070416/d8d40002/attachment.sig>