[Adium-devl] Patch attached to #5232

[Evan Schoenberg]

On Mar 31, 2007, at 12:53 AM, Brian Dickman wrote:

> First time patch submission, would like feedback.  FWIW, I was not
> able to edit the patch fields in the ticket, I got the impression from
> previous discussion this should be enabled...
It was enabled, then some kids decided to wreak havoc on Trac and we  
disabled property editing again.  We need to find an in-between  
solution, since it sucks to let the terrorists win, but we haven't  
found one yet.

> This lightly messes with the shadow settings, which I get the
> impression has been an issue before.  Whether a mistake or not, the
> old method of "only update shadows if opacity is < 90%" doesn't cut
> it, since actions which affect the window such as having a contact
> drop will leave a stale shadow (example shot in the ticket), plus some
> window modes are non-opaque even at 100% transparency.  I'm just
> turning on updateShadowsWhileDrawing for all non-opaque windows to
> deal with this.  Unleash the performance hounds.
> http://trac.adiumx.com/ticket/5232

I see, and you're right.  Sad that buggy shadow handling forces us to  
cut drawing performance like this for non-opaque windows with  
changing shadow-throwing borders... but I imagine that the set of  
users using (90% < opacity < 100%) isn't huge, and since most systems  
should be able to handle the extra drawing without a second thought,  
we'll err on the side of correct visual appearance.

Patch accepted and merged back to adium-1.0.

It'd be great if someone rocking a 10.5 build could test whether  
invalidateShadows is still necessary... :)
============
Index: Frameworks/Adium Framework/Source/AIListOutlineView.m
===================================================================
--- Frameworks/Adium Framework/Source/AIListOutlineView.m        
(revision 19310)
+++ Frameworks/Adium Framework/Source/AIListOutlineView.m        
(working copy)
@@ -388,7 +388,7 @@
          *
          *  XXX - ToDo: Check if this is still a problem in 10.4
          */
-       if (updateShadowsWhileDrawing) [[self window] invalidateShadow];
+       //if (updateShadowsWhileDrawing) [[self window]  
invalidateShadow];
}
- (AIGradient *)selectedControlGradient
============


-------------- next part --------------
A non-text attachment was scrubbed...
Name: PGP.sig
Type: application/pgp-signature
Size: 186 bytes
Desc: This is a digitally signed message part
URL: <http://adium.im/pipermail/devel_adium.im/attachments/20070401/4e4d6780/attachment.sig>