[Adium-devl] Toolbars in 1.0svn

[Kiel Gillard]

Hi Evan,

Sorry about the troubles! The compromise works well and does not re- 
break the block toolbar item. Will look into committing the patch  
soon once someone looks over it with me :-)

Kiel  :-)
"Few are those who see with their own eyes and feel with their own  
hearts."
Albert Einstein

On 27/03/2006, at 3:53 PM, Evan Schoenberg wrote:

> As mentioned in the comment above the method:
> This should be used rather than simply copying the existing  
> NSToolbarItem so custom copying behaviors to maintain custom view,  
> image, and menu settings are utilized.
>
> [15593] breaks custom views in toolbars when they are instantiated  
> via the AIToolbarUtilities classes.  I completely forgot about this  
> changeset and just spent 2 hours being mystified as to why the  
> search field in a toolbar was behaving as it were a different view  
> than the one I instantiated and stuck in the view; the reason was  
> that NSView doesn't conform to NSCopying.  Our custom copying  
> behavior sets the view on the new toolbar item; the non-custom  
> copying behavior instantiates a new view of the same class and  
> attempts to make it match.
>
> Technically, using the default copying behavior is Better... but  
> then we have to do all sorts of checking elsewhere if we stick a  
> custom view into a toolbar item and expect to be able to access  
> that view from elsewhere.  I've committed a compromise which I  
> think keeps your bug fixed but also makes custom views which can't  
> be copied do right.
>
> -Evan
>
> On Mar 25, 2006, at 9:07 PM, Kiel Gillard wrote:
>
>> Hey guys,
>>
>> In changeset 15593 I made a change to AIToolbarUtilities after  
>> consulting Mac-arena. If you're using svn builds regularly and you  
>> notice funky things happening with any of the toolbars, can you  
>> let me know? I'm itching to close ticket 1117 <http:// 
>> trac.adiumx.com/ticket/1117> (it should have been *real* easy to  
>> implement). I'd like to commit a patch to address 1117 in a weeks  
>> time at the most and the changeset mentioned above allows me to  
>> implement block toolbar item that works properly.
>>
>> Thanks!
>>
>> Kiel :-)
>> "Shoot for the moon. Even if you miss it you will land among the  
>> stars."
>> Les Brown
>>
>> _______________________________________________
>> Adium-devl mailing list
>> Adium-devl at adiumx.com
>> http://adiumx.com/mailman/listinfo/adium-devl_adiumx.com
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://adium.im/pipermail/devel_adium.im/attachments/20060327/3780b07f/attachment-0001.html>