adium 5898:8661cafccf3c: Fixed double release causing crash upon...
commits at adium.im
commits at adium.im
Wed Jan 14 16:12:43 UTC 2015
details: http://hg.adium.im/adium/rev/8661cafccf3c
revision: 5898:8661cafccf3c
branch: adium-1.5.11
author: Quentin Les <quentmail-spam at yahoo.fr>
date: Thu Sep 25 12:29:20 2014 +1000
Fixed double release causing crash upon file transfer completion on Bonjour. Fixes #16038, references #16182.
diffs (31 lines):
diff -r 63ff42d07432 -r 8661cafccf3c Copyright.txt
--- a/Copyright.txt Wed Jan 14 15:54:44 2015 +0100
+++ b/Copyright.txt Thu Sep 25 12:29:20 2014 +1000
@@ -69,6 +69,7 @@
Scott Lamb
Moses Lei
Adam Leonard
+Quentin Les
Chenguang Li
Jack M.H. Lin
Paul R. Livesey
diff -r 63ff42d07432 -r 8661cafccf3c Plugins/Bonjour/libezv/Classes/EKEzvIncomingFileTransfer.m
--- a/Plugins/Bonjour/libezv/Classes/EKEzvIncomingFileTransfer.m Wed Jan 14 15:54:44 2015 +0100
+++ b/Plugins/Bonjour/libezv/Classes/EKEzvIncomingFileTransfer.m Thu Sep 25 12:29:20 2014 +1000
@@ -316,7 +316,7 @@
[[[manager client] client] reportError:[NSString stringWithFormat: @"Download failed! Error - %@ %@",
[error localizedDescription],
[[error userInfo] objectForKey:NSURLErrorFailingURLStringErrorKey]] ofLevel: AWEzvError];
- [download release];
+ [currentDownloads removeObject:download];
}
- (void)downloadDidFinish:(NSURLDownload *)download
{
@@ -340,7 +340,6 @@
[[[manager client] client] updateProgressForFileTransfer:self percent:[NSNumber numberWithFloat:percentComplete] bytesSent:[NSNumber numberWithLongLong:bytesReceived]];
[currentDownloads removeObject:download];
- [download release];
}
- (void)download:(NSURLDownload *)download didReceiveResponse:(NSURLResponse *)response
{
More information about the commits
mailing list