adium 5834:9dae21c7e554: Fix a couple crashes due to controllers...
commits at adium.im
commits at adium.im
Sat Feb 1 17:18:41 UTC 2014
details: http://hg.adium.im/adium/rev/9dae21c7e554
revision: 5834:9dae21c7e554
branch: (none)
author: Frank Dowsett <wixardy at adium.im>
date: Sat Feb 01 12:15:32 2014 -0500
Fix a couple crashes due to controllers being released too early. Fixes #16579
diffs (37 lines):
diff -r 8f08f2a98915 -r 9dae21c7e554 Frameworks/Adium Framework/Source/AIAuthorizationRequestsWindowController.m
--- a/Frameworks/Adium Framework/Source/AIAuthorizationRequestsWindowController.m Wed Jan 08 15:24:30 2014 -0500
+++ b/Frameworks/Adium Framework/Source/AIAuthorizationRequestsWindowController.m Sat Feb 01 12:15:32 2014 -0500
@@ -114,14 +114,14 @@
- (void)windowWillClose:(id)sender
{
+ [super windowWillClose:sender];
+
// Fade into oblivion only if we don't have any oustanding requests.
if (!requests.count) {
sharedController = nil;
}
[[NSNotificationCenter defaultCenter] removeObserver:self];
-
- [super windowWillClose:sender];
}
#pragma mark Toolbar
diff -r 8f08f2a98915 -r 9dae21c7e554 Source/AISpecialPasswordPromptController.m
--- a/Source/AISpecialPasswordPromptController.m Wed Jan 08 15:24:30 2014 -0500
+++ b/Source/AISpecialPasswordPromptController.m Sat Feb 01 12:15:32 2014 -0500
@@ -111,11 +111,11 @@
*/
- (void)windowWillClose:(id)sender
{
+ [super windowWillClose:sender];
+
NSString *identifier = [AISpecialPasswordPromptController identifierForType:type name:name account:account];
[passwordPromptControllerDict removeObjectForKey:identifier];
-
- [super windowWillClose:sender];
}
/*!
More information about the commits
mailing list