adium 5730:4506bc638404: Fixed Facebook auth failure

[commits at adium.im]

details:	http://hg.adium.im/adium/rev/4506bc638404
revision:	5730:4506bc638404
branch:		(none)
author:		Michael DeFreitas <mikeylove at gmail.com>
date:		Fri Oct 25 22:43:07 2013 -0700

Fixed Facebook auth failure

(ticket #16494) Upon stepping through the Facebook authentication code, I noticed that the NSMutableData weak reference was getting nil'd out right away. The result was that a call downstream that expected some juicy json instead got a face full of nil. Reverted the instance property to not be weak.

diffs (35 lines):

diff -r 9d71987af7a0 -r 4506bc638404 Copyright.txt
--- a/Copyright.txt	Thu Oct 17 20:11:47 2013 -0400
+++ b/Copyright.txt	Fri Oct 25 22:43:07 2013 -0700
@@ -24,6 +24,7 @@
 Jacobo Tarragón Cros
 "ctbeiser"
 "dak180"
+Michael DeFreitas
 James De Ricco
 Brian Dickman
 Michael Dippery
diff -r 9d71987af7a0 -r 4506bc638404 Plugins/Purple Service/AIFacebookXMPPAccount.h
--- a/Plugins/Purple Service/AIFacebookXMPPAccount.h	Thu Oct 17 20:11:47 2013 -0400
+++ b/Plugins/Purple Service/AIFacebookXMPPAccount.h	Fri Oct 25 22:43:07 2013 -0700
@@ -36,7 +36,7 @@
     
     NSURLConnection *__weak connection;
     NSURLResponse *__weak connectionResponse;
-    NSMutableData *__weak connectionData;
+    NSMutableData *connectionData;
 	
 	NSDictionary *__weak migrationData;
 }
diff -r 9d71987af7a0 -r 4506bc638404 Plugins/Purple Service/AIFacebookXMPPAccount.m
--- a/Plugins/Purple Service/AIFacebookXMPPAccount.m	Thu Oct 17 20:11:47 2013 -0400
+++ b/Plugins/Purple Service/AIFacebookXMPPAccount.m	Fri Oct 25 22:43:07 2013 -0700
@@ -29,7 +29,7 @@
 @property (nonatomic, assign) NSUInteger networkState;
 @property (nonatomic, weak) NSURLConnection *connection; // assign because NSURLConnection retains its delegate.
 @property (weak, nonatomic) NSURLResponse *connectionResponse;
- at property (weak, nonatomic) NSMutableData *connectionData;
+ at property (nonatomic) NSMutableData *connectionData;
 
 - (void)meGraphAPIDidFinishLoading:(NSData *)graphAPIData response:(NSURLResponse *)response error:(NSError *)inError;
 - (void)promoteSessionDidFinishLoading:(NSData *)secretData response:(NSURLResponse *)response error:(NSError *)inError;