adium 5473:9905f4a21d11: I don't think these should be __weak.

commits at adium.im commits at adium.im
Tue May 7 16:52:08 UTC 2013


details:	http://hg.adium.im/adium/rev/9905f4a21d11
revision:	5473:9905f4a21d11
branch:		(none)
author:		Thijs Alkemade <me at thijsalkema.de>
date:		Tue May 07 18:50:42 2013 +0200

I don't think these should be __weak.

diffs (50 lines):

diff -r c7d875eb6574 -r 9905f4a21d11 Plugins/Purple Service/AMPurpleJabberNode.h
--- a/Plugins/Purple Service/AMPurpleJabberNode.h	Tue May 07 16:47:17 2013 +0200
+++ b/Plugins/Purple Service/AMPurpleJabberNode.h	Tue May 07 18:50:42 2013 +0200
@@ -34,9 +34,9 @@
 	NSString *infoIqId;
 	NSString *discoIqId;
 	
-	NSArray *__weak items;
-	NSSet *__weak features;
-	NSArray *__weak identities;
+	NSArray *items;
+	NSSet *features;
+	NSArray *identities;
 	
 	AMPurpleJabberNode *commands;
 	
@@ -51,10 +51,10 @@
 @property (readonly, copy, nonatomic) NSString *name;
 @property (readonly, copy, nonatomic) NSString *jid;
 @property (readonly, copy, nonatomic) NSString *node;
- at property (weak, readonly, nonatomic) NSArray *items;
- at property (weak, readonly, nonatomic) NSSet *features;
- at property (weak, readonly, nonatomic) NSArray *identities;
- at property (weak, readonly, nonatomic) NSArray *commands;
+ at property (readonly, nonatomic) NSArray *items;
+ at property (readonly, nonatomic) NSSet *features;
+ at property (readonly, nonatomic) NSArray *identities;
+ at property (readonly, nonatomic) NSArray *commands;
 @property (copy, nonatomic) NSString *infoIqId;
 @property (copy, nonatomic) NSString *discoIqId;
 
diff -r c7d875eb6574 -r 9905f4a21d11 Plugins/Purple Service/AMPurpleJabberNode.m
--- a/Plugins/Purple Service/AMPurpleJabberNode.m	Tue May 07 16:47:17 2013 +0200
+++ b/Plugins/Purple Service/AMPurpleJabberNode.m	Tue May 07 18:50:42 2013 +0200
@@ -22,12 +22,12 @@
 @property (readwrite, copy, nonatomic) NSString *name;
 @property (readwrite, copy, nonatomic) NSString *jid;
 @property (readwrite, copy, nonatomic) NSString *node;
- at property (weak, readwrite, nonatomic) NSSet *features;
- at property (weak, readwrite, nonatomic) NSArray *identities;
+ at property (readwrite, nonatomic) NSSet *features;
+ at property (readwrite, nonatomic) NSArray *identities;
 @property (readwrite, nonatomic, strong) AMPurpleJabberNode *commandsNode;
 @property (readwrite, assign, nonatomic) PurpleConnection *gc;
 @property (readwrite, nonatomic, strong) NSMutableArray *delegates;
- at property (weak, readwrite, nonatomic) NSArray *itemsArray;
+ at property (readwrite, nonatomic) NSArray *itemsArray;
 @end
 
 static CFArrayCallBacks nonretainingArrayCallbacks = {




More information about the commits mailing list