adium 5367:9dbadb96453e: Fix a couple of objects not being relea...
commits at adium.im
commits at adium.im
Mon Feb 25 23:09:28 UTC 2013
details: http://hg.adium.im/adium/rev/9dbadb96453e
revision: 5367:9dbadb96453e
branch: adium-1.5.5
author: Thijs Alkemade <thijsalkemade at gmail.com>
date: Mon Feb 25 22:06:24 2013 +0100
Fix a couple of objects not being released, being released but not removed from the UI or not zeroed after release.
This should fix the pretty common crash while Adium was quitting.
Refs #16257. Refs #16256.
diffs (31 lines):
diff -r ba11012569c9 -r 9dbadb96453e Source/AIStandardListWindowController.m
--- a/Source/AIStandardListWindowController.m Sun Feb 24 21:07:45 2013 +0100
+++ b/Source/AIStandardListWindowController.m Mon Feb 25 22:06:24 2013 +0100
@@ -137,7 +137,7 @@
- (void)windowWillClose:(NSNotification *)notification
{
[[NSNotificationCenter defaultCenter] removeObserver:self];
- [statusMenu release];
+ [statusMenu release]; statusMenu = nil;
[super windowWillClose:notification];
}
diff -r ba11012569c9 -r 9dbadb96453e Source/AIStateMenuPlugin.m
--- a/Source/AIStateMenuPlugin.m Sun Feb 24 21:07:45 2013 +0100
+++ b/Source/AIStateMenuPlugin.m Mon Feb 25 22:06:24 2013 +0100
@@ -79,9 +79,14 @@
- (void)uninstallPlugin
{
[[NSNotificationCenter defaultCenter] removeObserver:self];
-
+ [adium.menuController removeMenuItem:dockStatusMenuRoot];
+
[accountMenu release]; accountMenu = nil;
[statusMenu release]; statusMenu = nil;
+ [dockStatusMenuRoot release]; dockStatusMenuRoot = nil;
+ [currentMenuItemArray release]; currentMenuItemArray = nil;
+ [installedMenuItems release]; installedMenuItems = nil;
+ [socialNetworkingMenuItem release]; socialNetworkingMenuItem = nil;
}
/*!
More information about the commits
mailing list