adium 5342:b3407bf65d5f: For some people "Open Link" still shows...

commits at adium.im commits at adium.im
Thu Feb 21 20:07:31 UTC 2013


details:	http://hg.adium.im/adium/rev/b3407bf65d5f
revision:	5342:b3407bf65d5f
branch:		adium-1.6
author:		Thijs Alkemade <me at thijsalkema.de>
date:		Thu Feb 21 21:07:02 2013 +0100

For some people "Open Link" still shows up, allowing them to replace the message view with. Lets try to figure out what's going on here.

diffs (14 lines):

diff -r 8f5b3d78f567 -r b3407bf65d5f Plugins/WebKit Message View/AIWebKitMessageViewController.m
--- a/Plugins/WebKit Message View/AIWebKitMessageViewController.m	Tue Feb 19 21:16:29 2013 +0100
+++ b/Plugins/WebKit Message View/AIWebKitMessageViewController.m	Thu Feb 21 21:07:02 2013 +0100
@@ -874,8 +874,9 @@
 				[webViewMenuItems removeObjectIdenticalTo:menuItem];
 			} else {
 				//This isn't as nice; there's no tag available. Use the localization from WebKit to look at the title.
+				AILogWithSignature(@"Comparing [menuItem title] = %@ with NSLocalizedStringFromTableInBundle(@\"Open Link\", nil, [NSBundle bundleForClass:[WebView class]], nil) = %@", [menuItem title], NSLocalizedStringFromTableInBundle(@"Open Link", nil, [NSBundle bundleForClass:[WebView class]], nil));
 				if ([[menuItem title] isEqualToString:NSLocalizedStringFromTableInBundle(@"Open Link", nil, [NSBundle bundleForClass:[WebView class]], nil)])
-					[webViewMenuItems removeObjectIdenticalTo:menuItem];					
+					[webViewMenuItems removeObjectIdenticalTo:menuItem];
 			}
 		}
 	}




More information about the commits mailing list