adium 5300:4fb36aa7d54e: No need to check for -setHidden: anymore.

commits at adium.im commits at adium.im
Wed Feb 6 01:11:49 UTC 2013


details:	http://hg.adium.im/adium/rev/4fb36aa7d54e
revision:	5300:4fb36aa7d54e
branch:		adium-1.6
author:		Frank Dowsett <wixardy at adium.im>
date:		Tue Feb 05 18:52:36 2013 -0500

No need to check for -setHidden: anymore.
Subject: adium 5301:5388d630ef21: Updated PSMTabBarControl to https://github.com/wixardy/PSMTabBarControl/commit/d969586 which should fix #16286.

details:	http://hg.adium.im/adium/rev/5388d630ef21
revision:	5301:5388d630ef21
branch:		adium-1.6
author:		Frank Dowsett <wixardy at adium.im>
date:		Tue Feb 05 20:10:30 2013 -0500

Updated PSMTabBarControl to https://github.com/wixardy/PSMTabBarControl/commit/d969586 which should fix #16286.

diffs (78 lines):

diff -r 964b2ceb8716 -r 5388d630ef21 Frameworks/Adium Framework/Source/CSNewContactAlertWindowController.m
--- a/Frameworks/Adium Framework/Source/CSNewContactAlertWindowController.m	Tue Feb 05 23:57:28 2013 +0100
+++ b/Frameworks/Adium Framework/Source/CSNewContactAlertWindowController.m	Tue Feb 05 20:10:30 2013 -0500
@@ -148,11 +148,7 @@
 
 	// Remove the single-fire option for global
 	if (configureForGlobal) {
-		if ([checkbox_oneTime respondsToSelector:@selector(setHidden:)]) {
-			[checkbox_oneTime setHidden:YES];
-		} else {
-			[checkbox_oneTime setFrame:NSZeroRect];
-		}
+		[checkbox_oneTime setHidden:YES];
 	}
 	
 	// Set things up for the current event
diff -r 964b2ceb8716 -r 5388d630ef21 Frameworks/Adium Framework/Source/ESTextAndButtonsWindowController.m
--- a/Frameworks/Adium Framework/Source/ESTextAndButtonsWindowController.m	Tue Feb 05 23:57:28 2013 +0100
+++ b/Frameworks/Adium Framework/Source/ESTextAndButtonsWindowController.m	Tue Feb 05 20:10:30 2013 -0500
@@ -331,11 +331,7 @@
 		NSRect scrollFrame = [scrollView_message frame];
 		
 		//Remove the header area
-		if ([scrollView_messageHeader respondsToSelector:@selector(setHidden:)]) {
-			[scrollView_messageHeader setHidden:YES];
-		} else {
-			[scrollView_messageHeader setFrame:NSZeroRect];	
-		}
+		[scrollView_messageHeader setHidden:YES];
 		
 		//verticalChange is how far we can move our message area up since we don't have a messageHeader
 		CGFloat verticalChange = (messageHeaderFrame.size.height +
diff -r 964b2ceb8716 -r 5388d630ef21 Frameworks/PSMTabBarControl.framework/Versions/A/Headers/PSMProgressIndicator.h
--- a/Frameworks/PSMTabBarControl.framework/Versions/A/Headers/PSMProgressIndicator.h	Tue Feb 05 23:57:28 2013 +0100
+++ b/Frameworks/PSMTabBarControl.framework/Versions/A/Headers/PSMProgressIndicator.h	Tue Feb 05 20:10:30 2013 -0500
@@ -12,4 +12,5 @@
 @interface PSMProgressIndicator : NSProgressIndicator {
 }
 
- at end
\ No newline at end of file
+ at end
+
diff -r 964b2ceb8716 -r 5388d630ef21 Frameworks/PSMTabBarControl.framework/Versions/A/Headers/PSMTabStyle.h
--- a/Frameworks/PSMTabBarControl.framework/Versions/A/Headers/PSMTabStyle.h	Tue Feb 05 23:57:28 2013 +0100
+++ b/Frameworks/PSMTabBarControl.framework/Versions/A/Headers/PSMTabStyle.h	Tue Feb 05 20:10:30 2013 -0500
@@ -92,4 +92,5 @@
 - (CGFloat)leftMarginForTabBarControl DEPRECATED_ATTRIBUTE;
 - (CGFloat)rightMarginForTabBarControl DEPRECATED_ATTRIBUTE;
 - (CGFloat)topMarginForTabBarControl DEPRECATED_ATTRIBUTE;
- at end
\ No newline at end of file
+ at end
+
diff -r 964b2ceb8716 -r 5388d630ef21 Frameworks/PSMTabBarControl.framework/Versions/A/PSMTabBarControl
Binary file Frameworks/PSMTabBarControl.framework/Versions/A/PSMTabBarControl has changed
diff -r 964b2ceb8716 -r 5388d630ef21 Plugins/Link Management/SHLinkEditorWindowController.m
--- a/Plugins/Link Management/SHLinkEditorWindowController.m	Tue Feb 05 23:57:28 2013 +0100
+++ b/Plugins/Link Management/SHLinkEditorWindowController.m	Tue Feb 05 20:10:30 2013 -0500
@@ -297,17 +297,7 @@
 {
     // Validate our URL
     [textView_URL textDidChange:aNotification];
-	
-	if ([imageView_invalidURLAlert respondsToSelector:@selector(setHidden:)]) {
-        [imageView_invalidURLAlert setHidden:[textView_URL isURLValid]];
-
-    } else { // For those stuck in jag, we can't use setHidden
-        if ([textView_URL isURLValid]) {
-            [imageView_invalidURLAlert setImage:[NSImage imageNamed:@"space" forClass:[self class]]];
-        } else {
-            [imageView_invalidURLAlert setImage:[NSImage imageNamed:@"events-error-alert" forClass:[self class]]];
-        }
-    }
+    [imageView_invalidURLAlert setHidden:[textView_URL isURLValid]];
 }
 
 - (BOOL)textView:(NSTextView *)aTextView doCommandBySelector:(SEL)aSelector




More information about the commits mailing list