adium 5807:9886484d454b: Fix a possible overrelease in -changeNi...

commits at adium.im commits at adium.im
Tue Dec 17 09:30:31 UTC 2013


details:	http://hg.adium.im/adium/rev/9886484d454b
revision:	5807:9886484d454b
branch:		adium-1.6
author:		Thijs Alkemade <me at thijsalkema.de>
date:		Tue Dec 17 10:29:30 2013 +0100

Fix a possible overrelease in -changeNick:to:.

diffs (15 lines):

diff -r 197cd9ad019e -r 9886484d454b Frameworks/Adium Framework/Source/AIGroupChat.m
--- a/Frameworks/Adium Framework/Source/AIGroupChat.m	Fri Dec 06 14:16:21 2013 +0100
+++ b/Frameworks/Adium Framework/Source/AIGroupChat.m	Tue Dec 17 10:29:30 2013 +0100
@@ -297,9 +297,10 @@
 	[participatingNicksFlags removeObjectForKey:from];
 	if (flags) [participatingNicksFlags setObject:flags forKey:to];
 	
-	AIListObject *contact = [participatingNicksContacts objectForKey:from];
+	AIListObject *contact = [[participatingNicksContacts objectForKey:from] retain];
 	[participatingNicksContacts removeObjectForKey:from];
 	if (contact) [participatingNicksContacts setObject:contact forKey:to];
+	[contact release];
 }
 
 /*!




More information about the commits mailing list