adium 5418:5ee9e8200bf7: The overrelease fixed in http://hg.adiu...

commits at adium.im commits at adium.im
Tue Apr 16 15:00:32 UTC 2013


details:	http://hg.adium.im/adium/rev/5ee9e8200bf7
revision:	5418:5ee9e8200bf7
branch:		adium-1.5.7
author:		Thijs Alkemade <me at thijsalkema.de>
date:		Tue Apr 16 16:59:57 2013 +0200

The overrelease fixed in http://hg.adium.im/adium/rev/c71cfe104f07 actually turned into a leak in case the certificate required no user verification.

diffs (23 lines):

diff -r a705ec3e9e96 -r 5ee9e8200bf7 Plugins/Purple Service/AIPurpleCertificateTrustWarningAlert.m
--- a/Plugins/Purple Service/AIPurpleCertificateTrustWarningAlert.m	Tue Mar 26 23:54:18 2013 +0100
+++ b/Plugins/Purple Service/AIPurpleCertificateTrustWarningAlert.m	Tue Apr 16 16:59:57 2013 +0200
@@ -97,7 +97,10 @@
 
 - (void)dealloc {
 	CFRelease(certificates);
+	CFRelease(trustRef);
+	
 	[hostname release];
+	
 	[super dealloc];
 }
 
@@ -309,8 +312,6 @@
 	}
 
 	[trustpanel release];
-	CFRelease(trustRef);
-	trustRef = NULL;
 
 	[parentWindow performClose:nil];
 	




More information about the commits mailing list